From: Phillip Wood <phillip.wood123@gmail•com>
To: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Cc: Patrick Steinhardt <ps@pks•im>,
Phillip Wood <phillip.wood@dunelm•org.uk>
Subject: Re: [PATCH] docs: fix check-docs with WITH_BREAKING_CHANGES
Date: Sun, 9 Mar 2025 10:52:44 +0000 [thread overview]
Message-ID: <b5fb3292-216a-4456-b456-e9ed38affc22@gmail.com> (raw)
In-Reply-To: <56cf842a-7c1f-4354-b191-35bcc1e139bd@gmail.com>
On 07/03/2025 15:07, Phillip Wood wrote:
> On 07/03/2025 10:32, Phillip Wood wrote:
>
> The diff below stops us from building pack-redundant with
> -Dbreaking_changes=true but still builds the documentation. I don't intend
> spending any more time one this
>
> [...]
>
> if get_option('breaking_changes')
> build_options_config.set('WITH_BREAKING_CHANGES', 'YesPlease')
> + add_project_arguments('-DWITH_BREAKING_CHANGES=YesPlease', language :
> 'c')
Looking again at this I think it should probably be
libgit_c_args += '-DWITH_BREAKING_CHANGES=YesPlease'
to match the rest of our meson.build. As a newcomer to meson I find it
confusing that the CFLAGS for the build targets are set implicitly by
their libgit dependency.
Best Wishes
Phillip
next prev parent reply other threads:[~2025-03-09 10:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-03 16:11 [PATCH] docs: fix repository-layout when building with breaking changes Phillip Wood via GitGitGadget
2025-03-03 18:18 ` Junio C Hamano
2025-03-04 6:35 ` Patrick Steinhardt
2025-03-04 10:23 ` Phillip Wood
2025-03-04 16:04 ` Junio C Hamano
2025-03-05 10:42 ` [PATCH v2] " Phillip Wood via GitGitGadget
2025-03-05 15:53 ` [PATCH] docs: fix check-docs with WITH_BREAKING_CHANGES Junio C Hamano
2025-03-07 10:32 ` Phillip Wood
2025-03-07 15:07 ` Phillip Wood
2025-03-07 19:55 ` Junio C Hamano
2025-03-07 22:42 ` Karthik Nayak
2025-03-09 10:52 ` Phillip Wood
2025-03-09 10:52 ` Phillip Wood [this message]
2025-03-10 6:42 ` Patrick Steinhardt
2025-03-11 14:40 ` Patrick Steinhardt
2025-03-12 10:39 ` phillip.wood123
2025-03-12 13:43 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b5fb3292-216a-4456-b456-e9ed38affc22@gmail.com \
--to=phillip.wood123@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox