Subject: Re: [PATCH v3 3/8] reftable: check for trailing newline in 'tables.list'

From: "Kristoffer Haugsbakk" <[email-masked]>
Date: Wed, 24 Sep 2025 09:24:57 +0200

On Thu, Sep 18, 2025, at 10:11, Karthik Nayak wrote:
> In the reftable format, the 'tables.list' file contains a newline
> separated list of tables. While we parse this file, we do not check or
> care about trailing newlines. Tighten the parser in `parse_names()` to
> return an appropriate error if there is no trailing newline.

Nit:[1] newline-separated + requiring a trailing newline sounds like it
really equals: newline-terminated list.  Is this moving from
effectively using newline-separated to a newline-terminated format?

† 1: Since others have commented anyway

>
> This requires modification to `parse_names()` to accept a third argument
> which will hold the error value.
>
> Signed-off-by: Karthik Nayak <[email-masked]>
> ---