From: Johannes Sixt <j6t@kdbg•org>
To: Junio C Hamano <gitster@pobox•com>
Cc: "brian m. carlson" <sandals@crustytoothpaste•net>,
"Carlo Marcelo Arenas Belón" <carenas@gmail•com>,
"Stefan Haller" <lists@haller-berlin•de>,
Git <git@vger•kernel.org>, "Elijah Newren" <newren@gmail•com>
Subject: Re: Would it make sense to add a commit.signOff config?
Date: Tue, 16 Dec 2025 08:10:30 +0100 [thread overview]
Message-ID: <be069975-8b0f-4915-8c50-0dcbf6efb142@kdbg.org> (raw)
In-Reply-To: <xmqqwm2n40sf.fsf@gitster.g>
Am 16.12.25 um 03:29 schrieb Junio C Hamano:
> Elijah Newren <newren@gmail•com> writes:
>
>>> diff --git c/Documentation/signoff-option.adoc w/Documentation/signoff-option.adoc
>>> index cddfb225d1..0b869dfbe4 100644
>>> --- c/Documentation/signoff-option.adoc
>>> +++ w/Documentation/signoff-option.adoc
>>> @@ -16,3 +16,15 @@ endif::git-commit[]
>>> +
>>> The `--no-signoff` option can be used to countermand an earlier `--signoff`
>>> option on the command line.
>>> ++
>>> +As it makes it harder to argue against one who tells the court "the
>>> +log message of the commit ends with a Signed-off-by trailer by person
>>> +X, but it is very plausible that it was done by inertia without person
>>> +X really intending to certify what DCO says, hence the Signed-off-by
>>> +trailer is meaningless", if we add more publicized ways to add
>>> +sign-off automatically, Git does not (and will not) have a
>>> +configuration variable to enable the `--signoff` command line option
>>> +it by default.
>>> ++
>>> +There exists `format.signoff`, but that is a historical mistake, and
>>> +it is not an excuse to pile on more mistakes of the same kind on top.
>>
>> This feels like it's missing context (it'll take the reader a while to
>> figure out why the paragraphs are there and that the two are related),
>
> Very true. It may be sufficient to leave this part unmodified,
> keep the updates to gitfaq document, and do nothing else.
Please do leave a pointer here. People who want to automate --signoff do
not visit gitfaq, but will search in the command's manual page.
-- Hannes
next prev parent reply other threads:[~2025-12-16 7:52 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 16:10 Would it make sense to add a commit.signOff config? Stefan Haller
2025-12-14 16:44 ` Carlo Marcelo Arenas Belón
2025-12-14 23:44 ` Junio C Hamano
2025-12-14 23:52 ` Collin Funk
2025-12-15 1:22 ` brian m. carlson
2025-12-15 1:59 ` Junio C Hamano
2025-12-15 22:29 ` brian m. carlson
2025-12-16 1:20 ` Junio C Hamano
2025-12-16 0:17 ` Elijah Newren
2025-12-16 2:29 ` Junio C Hamano
2025-12-16 7:10 ` Johannes Sixt [this message]
2025-12-16 7:15 ` Johannes Sixt
2025-12-16 18:54 ` [PATCH v2] commit: document that $command.signoff will not be added Junio C Hamano
2025-12-16 19:48 ` Elijah Newren
2025-12-17 4:47 ` Junio C Hamano
2025-12-17 7:40 ` Elijah Newren
2025-12-17 13:51 ` Johannes Sixt
2025-12-17 23:16 ` Junio C Hamano
2025-12-19 7:33 ` Kristoffer Haugsbakk
2025-12-19 12:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be069975-8b0f-4915-8c50-0dcbf6efb142@kdbg.org \
--to=j6t@kdbg$(echo .)org \
--cc=carenas@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=lists@haller-berlin$(echo .)de \
--cc=newren@gmail$(echo .)com \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox