From: Miles Bader <miles@gnu•org>
To: Ramkumar Ramachandra <artagnon@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
Jonathan Nieder <jrnieder@gmail•com>,
Git List <git@vger•kernel.org>
Subject: Re: [PATCH 1/5] sequencer: factor code out of revert builtin
Date: Tue, 15 Nov 2011 18:18:33 +0900 [thread overview]
Message-ID: <buo4ny5u4k6.fsf@dhlpc061.dev.necel.com> (raw)
In-Reply-To: <CALkWK0mtmRYyFosQNJixhheUmHpRjWc4A5zPQ6AaBfmw4H4eLQ@mail.gmail.com>
Ramkumar Ramachandra <artagnon@gmail•com> writes:
> Junio C Hamano writes:
>> [...]
>> With that observation, it would probably make more sense if "foo.c"
>> included the headers in the following order:
>>
>> - Anything the declarations in "foo.h" depends on;
>> - "foo.h" itself; and finally
>> - Other headers that "foo.c" implementation needs.
>>
>> That way, people who want to use "foo.h" can guess what needs to be
>> included before using "foo.h" a lot more easily.
>
> That's a good rule-of-thumb. Thanks :)
Does git not use the common practice of self-contained headers?
-miles
--
Fast, small, soon; pick any 2.
next prev parent reply other threads:[~2011-11-15 9:18 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-05 16:29 [PATCH 0/5] Sequencer: working around historical mistakes Ramkumar Ramachandra
2011-11-05 16:29 ` [PATCH 1/5] sequencer: factor code out of revert builtin Ramkumar Ramachandra
2011-11-06 0:12 ` Jonathan Nieder
2011-11-13 10:40 ` Ramkumar Ramachandra
2011-11-13 23:10 ` Junio C Hamano
2011-11-15 9:00 ` Ramkumar Ramachandra
2011-11-15 9:18 ` Miles Bader [this message]
2011-11-15 9:47 ` Jonathan Nieder
2011-11-05 16:29 ` [PATCH 2/5] sequencer: remove CHERRY_PICK_HEAD with sequencer state Ramkumar Ramachandra
2011-11-06 0:15 ` Jonathan Nieder
2011-11-05 16:29 ` [PATCH 3/5] sequencer: sequencer state is useless without todo Ramkumar Ramachandra
2011-11-06 0:26 ` Jonathan Nieder
2011-11-13 10:44 ` Ramkumar Ramachandra
2011-11-13 20:50 ` Junio C Hamano
2011-11-15 9:13 ` Ramkumar Ramachandra
2011-11-15 9:52 ` Jonathan Nieder
2011-11-15 16:27 ` Junio C Hamano
2011-11-16 6:17 ` Ramkumar Ramachandra
2011-11-16 7:38 ` Junio C Hamano
2011-11-16 7:59 ` [PATCH 0/3] avoiding unintended consequences of git_path() usage Jonathan Nieder
2011-11-16 8:03 ` [PATCH 1/3] do not let git_path clobber errno when reporting errors Jonathan Nieder
2011-11-16 8:04 ` [PATCH 2/3] Bigfile: dynamically allocate buffer for marks file name Jonathan Nieder
2011-11-16 8:07 ` [PATCH 3/3] rename git_path() to git_path_unsafe() Jonathan Nieder
2011-11-17 1:20 ` Junio C Hamano
2011-11-17 7:03 ` Jonathan Nieder
2011-11-16 8:37 ` [PATCH 0/3] avoiding unintended consequences of git_path() usage Nguyen Thai Ngoc Duy
2011-11-16 8:42 ` Nguyen Thai Ngoc Duy
2011-11-16 8:59 ` Jonathan Nieder
2011-11-16 9:31 ` Nguyen Thai Ngoc Duy
2011-11-19 19:25 ` Ramsay Jones
2011-11-16 21:50 ` [PATCH/RFC] introduce strbuf_addpath() Jonathan Nieder
2011-11-18 1:42 ` Nguyen Thai Ngoc Duy
2011-11-16 22:04 ` [PATCH 0/3] avoiding unintended consequences of git_path() usage Junio C Hamano
2011-11-16 8:51 ` Ramkumar Ramachandra
2011-11-16 13:33 ` Nguyen Thai Ngoc Duy
2011-11-16 13:44 ` Michael Haggerty
2011-11-18 3:33 ` Nguyen Thai Ngoc Duy
2011-11-05 16:29 ` [PATCH 4/5] sequencer: handle single commit pick separately Ramkumar Ramachandra
2011-11-06 0:35 ` Jonathan Nieder
2011-11-05 16:29 ` [PATCH 5/5] sequencer: revert d3f4628e Ramkumar Ramachandra
2011-11-06 0:42 ` Jonathan Nieder
2011-11-06 19:10 ` Junio C Hamano
2011-11-07 6:06 ` Ramkumar Ramachandra
2011-11-12 16:13 ` Ramkumar Ramachandra
2011-11-12 22:40 ` Jonathan Nieder
2011-11-05 23:43 ` [PATCH 0/5] Sequencer: working around historical mistakes Jonathan Nieder
2011-11-13 10:42 ` Ramkumar Ramachandra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=buo4ny5u4k6.fsf@dhlpc061.dev.necel.com \
--to=miles@gnu$(echo .)org \
--cc=artagnon@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=jrnieder@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox