public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Derrick Stolee <derrickstolee@github•com>
To: "Git Mailing List" <git@vger•kernel.org>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail•com>,
	"Taylor Blau" <me@ttaylorr•com>,
	"Christian Couder" <christian.couder@gmail•com>,
	"Jeff Hostetler" <git@jeffhostetler•com>,
	"Neeraj Singh" <nksingh85@gmail•com>
Subject: Re: Git Test Coverage Report for v2.37.0-rc0
Date: Tue, 14 Jun 2022 16:34:18 -0400	[thread overview]
Message-ID: <cdc0cba8-bd9d-9299-a769-aa7b522520ae@github.com> (raw)
In-Reply-To: <3d1c6dfd-1df6-3393-df5e-692719375772@github.com>

On 6/14/2022 4:20 PM, Derrick Stolee wrote:
> On 6/14/2022 4:18 PM, Derrick Stolee wrote:
>> Derrick Stolee	b56166ca multi-pack-index: use --object-dir real path
>> builtin/multi-pack-index.c
>> b56166ca 61) opts.object_dir = xstrdup(get_object_directory());
> 
> This is demonstrating that opts.object_dir is never populated before
> we parse the options. We must be handling a NULL object_dir properly
> somewhere else. I'll work on a patch to fix this.

I was looking at the wrong line. This line is testing the --no-object-dir
option, which is fine to leave untested, probably.

Thanks,
-Stolee

next prev parent reply	other threads:[~2022-06-14 20:34 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 20:18 Git Test Coverage Report for v2.37.0-rc0 Derrick Stolee
2022-06-14 20:20 ` Derrick Stolee
2022-06-14 20:34   ` Derrick Stolee [this message]
2022-06-14 23:46   ` Taylor Blau
2022-06-15 10:16   ` Ævar Arnfjörð Bjarmason
2022-06-15 13:21     ` Derrick Stolee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cdc0cba8-bd9d-9299-a769-aa7b522520ae@github.com \
    --to=derrickstolee@github$(echo .)com \
    --cc=avarab@gmail$(echo .)com \
    --cc=christian.couder@gmail$(echo .)com \
    --cc=git@jeffhostetler$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=me@ttaylorr$(echo .)com \
    --cc=nksingh85@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox