Subject: Re: [PATCH v4 0/2] bundle-uri: copy all bundle references ino the refs/bundle space

From: Phillip Wood <[email-masked]>
Date: Fri, 25 Apr 2025 14:53:44 +0100

Hi Scott

On 25/04/2025 14:17, Scott Chacon via GitGitGadget wrote:
> Updated the test with Taylor's patch.

Thanks for updating the test, unfortunately the documentation update 
mentioned in [1] to ensure the refspec in the documentation matches the 
changes in this series seems to have been overlooked.

Best Wishes

Phillip

[1] 
https://lore.kernel.org/git/[email-masked]/

>> bundle-uri: copy all bundle references ino the refs/bundle space
>> bundle-uri: update bundle clone tests with new refspec path
> 
> Scott Chacon (2):
>    bundle-uri: copy all bundle references ino the refs/bundle space
>    bundle-uri: add test for bundle-uri clones with tags
> 
>   bundle-uri.c                |   2 +-
>   t/t5558-clone-bundle-uri.sh | 202 +++++++++++++++++++++---------------
>   2 files changed, 117 insertions(+), 87 deletions(-)
> 
> 
> base-commit: f65182a99e545d2f2bc22e6c1c2da192133b16a3
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1897%2Fschacon%2Fsc-more-bundle-refs-v4
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1897/schacon/sc-more-bundle-refs-v4
> Pull-Request: https://github.com/git/git/pull/1897
> 
> Range-diff vs v3:
> 
>   1:  2ccbfdcc2dc = 1:  6957ee2fed2 bundle-uri: copy all bundle references ino the refs/bundle space
>   2:  d148b14c390 ! 2:  d9a114915a3 bundle-uri: add test for bundle-uri clones with tags
>       @@ Commit message
>            bundle-uri: add test for bundle-uri clones with tags
>        
>            The change to the bundle-uri unbundling refspec now includes tags, so this
>       -    adds a simple test to make sure that tags in a bundle are properly added to
>       -    the cloned repository and will be included in ref negotiation with the
>       -    subsequent fetch.
>       +    adds a very, very simple test to make sure that tags in a bundle are
>       +    properly added to the cloned repository and will be included in ref
>       +    negotiation with the subsequent fetch. ok, now it's right. christ.
>        
>            Signed-off-by: Scott Chacon <[email-masked]>
>        
>       @@ t/t5558-clone-bundle-uri.sh: test_expect_success 'clone with file:// bundle' '
>        +test_expect_success 'clone with tags bundle' '
>        +	git clone --bundle-uri="clone-from-tags/ALL.bundle" \
>        +		clone-from-tags clone-tags-path &&
>       -+	git -C clone-tags-path for-each-ref --format="%(refname)" >refs &&
>       -+	grep "refs/bundles/tags/" refs >actual &&
>       -+	cat >expect <<-\EOF &&
>       -+	refs/bundles/tags/A
>       -+	refs/bundles/tags/B
>       -+	refs/bundles/tags/tag-A
>       -+	EOF
>       ++
>       ++	git -C clone-from-tags for-each-ref --format="%(refname:lstrip=1)" \
>       ++		>expect &&
>       ++	git -C clone-tags-path for-each-ref --format="%(refname:lstrip=2)" \
>       ++		refs/bundles >actual &&
>       ++
>        +	test_cmp expect actual
>        +'
>        +
>