public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Jonathan Tan <jonathantanmy@google•com>
To: git@vger•kernel.org
Cc: Jonathan Tan <jonathantanmy@google•com>,
	Dragan Simic <dsimic@manjaro•org>,
	 Phillip Wood <phillip.wood123@gmail•com>,
	Junio C Hamano <gitster@pobox•com>
Subject: [PATCH v2 0/4] Avoid passing global comment_line_char repeatedly
Date: Tue, 31 Oct 2023 15:28:29 -0700	[thread overview]
Message-ID: <cover.1698791220.git.jonathantanmy@google.com> (raw)
In-Reply-To: <db6702ba-11a7-44c1-af2a-95b080aaeb77@gmail.com>

Here's an updated patchset. The first 2 are the exact same as what Junio
has sent.

Jonathan Tan (2):
  strbuf: make add_lines() public
  strbuf: move env-using functions to environment.c

Junio C Hamano (2):
  strbuf_commented_addf(): drop the comment_line_char parameter
  strbuf_add_commented_lines(): drop the comment_line_char parameter

 add-patch.c          |  8 +++----
 builtin/branch.c     |  2 +-
 builtin/merge.c      |  8 +++----
 builtin/notes.c      |  9 ++++----
 builtin/stripspace.c |  2 +-
 builtin/tag.c        |  4 ++--
 environment.c        | 32 +++++++++++++++++++++++++++
 environment.h        | 14 ++++++++++++
 fmt-merge-msg.c      |  9 +++-----
 rebase-interactive.c |  8 +++----
 sequencer.c          | 14 ++++++------
 strbuf.c             | 51 +++++++++-----------------------------------
 strbuf.h             | 20 ++++-------------
 wt-status.c          |  6 +++---
 14 files changed, 92 insertions(+), 95 deletions(-)

-- 
2.42.0.820.g83a721a137-goog


  parent reply	other threads:[~2023-10-31 22:28 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-30  5:10 [PATCH 0/2] Avoid passing global comment_line_char repeatedly Junio C Hamano
2023-10-30  5:10 ` [PATCH 1/2] strbuf_commented_addf(): drop the comment_line_char parameter Junio C Hamano
2023-10-30  5:10 ` [PATCH 2/2] strbuf_add_commented_lines(): " Junio C Hamano
2023-10-30  5:36 ` [PATCH 0/2] Avoid passing global comment_line_char repeatedly Dragan Simic
2023-10-30  9:59 ` Phillip Wood
2023-10-30 20:22   ` [RFC PATCH 0/3] " Jonathan Tan
2023-10-30 20:22     ` [RFC PATCH 1/3] strbuf: make add_lines() public Jonathan Tan
2023-10-30 23:53       ` Junio C Hamano
2023-10-31  6:01         ` Junio C Hamano
2023-10-30 20:22     ` [RFC PATCH 2/3] strbuf_commented_addf(): drop the comment_line_char parameter Jonathan Tan
2023-10-31  5:19       ` Junio C Hamano
2023-10-31 22:24         ` Jonathan Tan
2023-10-31 23:54           ` Junio C Hamano
2023-10-30 20:22     ` [RFC PATCH 3/3] strbuf_add_commented_lines(): " Jonathan Tan
2023-10-31 22:28   ` Jonathan Tan [this message]
2023-10-31 22:28     ` [PATCH v2 1/4] strbuf_commented_addf(): " Jonathan Tan
2023-10-31 22:28     ` [PATCH v2 2/4] strbuf_add_commented_lines(): " Jonathan Tan
2023-10-31 22:28     ` [PATCH v2 3/4] strbuf: make add_lines() public Jonathan Tan
2023-11-01  4:14       ` Junio C Hamano
2023-10-31 22:28     ` [PATCH v2 4/4] strbuf: move env-using functions to environment.c Jonathan Tan
2023-11-01  4:37       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1698791220.git.jonathantanmy@google.com \
    --to=jonathantanmy@google$(echo .)com \
    --cc=dsimic@manjaro$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=phillip.wood123@gmail$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox