From: Jiang Xin <worldhello.net@gmail•com>
To: git@vger•kernel.org, Patrick Steinhardt <ps@pks•im>
Cc: Jiang Xin <zhiyou.jx@alibaba-inc•com>,
Larry D'Anna <larry@elder-gods•org>
Subject: [PATCH v2 0/6] fix behaviors of git-push --porcelain
Date: Fri, 15 Nov 2024 01:15:31 +0800 [thread overview]
Message-ID: <cover.1731603991.git.zhiyou.jx@alibaba-inc.com> (raw)
In-Reply-To: <CANYiYbHGdJsTgdzJj1r4sPdTAcZCf3C-qA538fcXbD1jjB1BUw@mail.gmail.com>
From: Jiang Xin <zhiyou.jx@alibaba-inc•com>
When executing git-push(1) with the "--porcelain" flag, then we will
print updated references in a machine-readable format that looks
like this:
To destination
= refs/heads/noop:refs/heads/noop [up to date]
! refs/heads/rejected:refs/heads/rejected [rejected] (atomic push
failed)
! refs/heads/noff:refs/heads/(off (non-fast-forward)
Done
The final "Done" stanza was introduced via 77555854be (git-push:
make git push --porcelain print "Done", 2010-02-26), with the
following behaviors:
- Show a "Done" porcelain message if there are no errors.
- Fail to update a ref in a --dry-run does not count as an error.
- Actual rejections in non --dry-run pushes do count as errors.
- Return a non-zero exit code if there are errors.
This patch series try to fix the broken behaviors introduced in
commit 7dcbeaa0df (send-pack: fix inconsistent porcelain output,
2020-04-17).
--
Jiang Xin (4):
t5548: new test cases for push --porcelain and --dry-run
push: fix the behavior of the Done message for porcelain
push: only ignore finish_connect() for dry-run mode
push: not send push-options to server with --dry-run
Patrick Steinhardt (2):
t5504: modernize test by moving heredocs into test bodies
t5543: atomic push reports exit code failure
send-pack.c | 13 +-
.../test-0001-standard-git-push--porcelain.sh | 1 -
...st-0003-pre-receive-declined--porcelain.sh | 1 -
t/t5411/test-0012-no-hook-error--porcelain.sh | 2 -
t/t5411/test-0014-bad-protocol--porcelain.sh | 9 -
t/t5411/test-0021-report-ng--porcelain.sh | 2 -
...est-0023-report-unexpect-ref--porcelain.sh | 1 -
...test-0025-report-unknown-ref--porcelain.sh | 1 -
...est-0033-report-with-options--porcelain.sh | 1 -
.../test-0039-report-mixed-refs--porcelain.sh | 1 -
t/t5504-fetch-receive-strict.sh | 34 +-
t/t5516-fetch-push.sh | 3 +-
t/t5534-push-signed.sh | 1 -
t/t5541-http-push-smart.sh | 1 -
t/t5543-atomic-push.sh | 30 ++
t/t5548-push-porcelain.sh | 335 +++++++++++++-----
transport.c | 21 +-
17 files changed, 316 insertions(+), 141 deletions(-)
--
2.47.0.rc1.21.g81e7bd6151
next prev parent reply other threads:[~2024-11-14 17:15 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 11:24 [PATCH 0/2] transport: don't ignore git-receive-pack(1) exit code on atomic push Patrick Steinhardt
2024-11-13 11:24 ` [PATCH 1/2] t5504: modernize test by moving heredocs into test bodies Patrick Steinhardt
2024-11-13 11:24 ` [PATCH 2/2] transport: don't ignore git-receive-pack(1) exit code on atomic push Patrick Steinhardt
2024-11-14 8:57 ` Jiang Xin
2024-11-14 17:15 ` Jiang Xin [this message]
2024-11-14 17:15 ` [PATCH v2 1/6] t5548: new test cases for push --porcelain and --dry-run Jiang Xin
2024-11-25 8:26 ` Patrick Steinhardt
2024-12-03 11:52 ` Jiang Xin
2024-11-14 17:15 ` [PATCH v2 2/6] push: fix the behavior of the Done message for porcelain Jiang Xin
2024-11-25 8:26 ` Patrick Steinhardt
2024-11-14 17:15 ` [PATCH v2 3/6] t5504: modernize test by moving heredocs into test bodies Jiang Xin
2024-11-14 17:15 ` [PATCH v2 4/6] t5543: atomic push reports exit code failure Jiang Xin
2024-11-14 17:15 ` [PATCH v2 5/6] push: only ignore finish_connect() for dry-run mode Jiang Xin
2024-11-25 8:26 ` Patrick Steinhardt
2024-11-14 17:15 ` [PATCH v2 6/6] push: not send push-options to server with --dry-run Jiang Xin
2024-11-25 8:26 ` Patrick Steinhardt
2024-12-10 11:36 ` [PATCH v3 0/8] fix behaviors of git-push --porcelain Jiang Xin
2024-12-10 11:36 ` [PATCH v3 1/8] t5504: modernize test by moving heredocs into test bodies Jiang Xin
2024-12-10 11:36 ` [PATCH v3 2/8] t5548: refactor to reuse setup_upstream() function Jiang Xin
2024-12-10 11:36 ` [PATCH v3 3/8] t5548: refactor test cases by resetting upstream Jiang Xin
2024-12-10 11:36 ` [PATCH v3 4/8] t5548: add new porcelain test cases Jiang Xin
2024-12-10 11:36 ` [PATCH v3 5/8] t5548: add porcelain push test cases for dry-run mode Jiang Xin
2024-12-10 12:19 ` Jiang Xin
2024-12-10 11:36 ` [PATCH v3 6/8] send-pack: new return code "ERROR_SEND_PACK_BAD_REF_STATUS" Jiang Xin
2024-12-16 8:36 ` Patrick Steinhardt
2024-12-10 11:36 ` [PATCH v3 7/8] t5543: atomic push reports exit code failure Jiang Xin
2024-12-10 11:36 ` [PATCH v3 8/8] send-pack: gracefully close the connection for atomic push Jiang Xin
2024-12-16 8:36 ` Patrick Steinhardt
2024-11-14 23:36 ` [PATCH 2/2] transport: don't ignore git-receive-pack(1) exit code on " Junio C Hamano
2024-11-25 8:26 ` Patrick Steinhardt
2025-01-31 10:53 ` [PATCH v4 0/8] " Patrick Steinhardt
2025-01-31 10:53 ` [PATCH v4 1/8] t5504: modernize test by moving heredocs into test bodies Patrick Steinhardt
2025-01-31 14:28 ` Eric Sunshine
2025-01-31 16:26 ` Junio C Hamano
2025-02-03 6:04 ` Patrick Steinhardt
2025-01-31 10:53 ` [PATCH v4 2/8] t5548: refactor to reuse setup_upstream() function Patrick Steinhardt
2025-01-31 14:35 ` Eric Sunshine
2025-01-31 10:53 ` [PATCH v4 3/8] t5548: refactor test cases by resetting upstream Patrick Steinhardt
2025-01-31 10:53 ` [PATCH v4 4/8] t5548: add new porcelain test cases Patrick Steinhardt
2025-01-31 14:46 ` Eric Sunshine
2025-01-31 10:53 ` [PATCH v4 5/8] t5548: add porcelain push test cases for dry-run mode Patrick Steinhardt
2025-01-31 10:53 ` [PATCH v4 6/8] send-pack: new return code "ERROR_SEND_PACK_BAD_REF_STATUS" Patrick Steinhardt
2025-01-31 10:53 ` [PATCH v4 7/8] t5543: atomic push reports exit code failure Patrick Steinhardt
2025-01-31 10:53 ` [PATCH v4 8/8] send-pack: gracefully close the connection for atomic push Patrick Steinhardt
2025-02-03 6:29 ` [PATCH v5 0/8] transport: don't ignore git-receive-pack(1) exit code on " Patrick Steinhardt
2025-02-03 6:29 ` [PATCH v5 1/8] t5504: modernize test by moving heredocs into test bodies Patrick Steinhardt
2025-02-03 6:29 ` [PATCH v5 2/8] t5548: refactor to reuse setup_upstream() function Patrick Steinhardt
2025-02-03 6:29 ` [PATCH v5 3/8] t5548: refactor test cases by resetting upstream Patrick Steinhardt
2025-02-03 6:29 ` [PATCH v5 4/8] t5548: add new porcelain test cases Patrick Steinhardt
2025-02-03 6:29 ` [PATCH v5 5/8] t5548: add porcelain push test cases for dry-run mode Patrick Steinhardt
2025-02-03 6:29 ` [PATCH v5 6/8] send-pack: new return code "ERROR_SEND_PACK_BAD_REF_STATUS" Patrick Steinhardt
2025-02-03 6:29 ` [PATCH v5 7/8] t5543: atomic push reports exit code failure Patrick Steinhardt
2025-02-03 6:29 ` [PATCH v5 8/8] send-pack: gracefully close the connection for atomic push Patrick Steinhardt
2025-02-03 23:26 ` [PATCH v5 0/8] transport: don't ignore git-receive-pack(1) exit code on " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1731603991.git.zhiyou.jx@alibaba-inc.com \
--to=worldhello.net@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=larry@elder-gods$(echo .)org \
--cc=ps@pks$(echo .)im \
--cc=zhiyou.jx@alibaba-inc$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox