public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail•com>
To: "Aaron Plattner" <aplattner@nvidia•com>,
	git@vger•kernel.org, "Junio C Hamano" <gitster@pobox•com>
Cc: "Patrick Steinhardt" <ps@pks•im>,
	"Rahul Rameshbabu" <rrameshbabu@nvidia•com>,
	"Lucas De Marchi" <demarchi@kernel•org>
Subject: Re: [PATCH v4] remote-curl: use auth for probe_rpc() requests too
Date: Wed, 14 Jan 2026 15:34:11 +0100	[thread overview]
Message-ID: <d666df1e-2645-4597-ad10-be22d6a52ba5@app.fastmail.com> (raw)
In-Reply-To: <20260114010642.594566-2-aplattner@nvidia.com>

On Wed, Jan 14, 2026, at 02:06, Aaron Plattner wrote:
>[snip]
>
> Signed-off-by: Aaron Plattner <aplattner@nvidia•com>
> Tested-by: Lucas De Marchi <demarchi@kernel•org>

Unrelated nitpick: It is more common in this project to have your signoff last. 
If the maintainer applies this patch:

    Signed-off-by: Aaron Plattner <aplattner@nvidia•com>
    Tested-by: Lucas De Marchi <demarchi@kernel•org>
    Signed-off-by: The Maintainer <>

It looks like The Maintainer added the `Tested-by` trailer.

At least this is my experience with `Acked-by`.

> ---
> v4: Style nitpicks, use xargs in case 2000 branches is too many for the command
> line.
>[snip]

      reply	other threads:[~2026-01-14 14:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-14  1:06 [PATCH v4] remote-curl: use auth for probe_rpc() requests too Aaron Plattner
2026-01-14 14:34 ` Kristoffer Haugsbakk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d666df1e-2645-4597-ad10-be22d6a52ba5@app.fastmail.com \
    --to=kristofferhaugsbakk@fastmail$(echo .)com \
    --cc=aplattner@nvidia$(echo .)com \
    --cc=demarchi@kernel$(echo .)org \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitster@pobox$(echo .)com \
    --cc=ps@pks$(echo .)im \
    --cc=rrameshbabu@nvidia$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox