From: Phillip Wood <phillip.wood123@gmail•com>
To: Junio C Hamano <gitster@pobox•com>,
David Mandelberg <david@mandelberg•org>
Cc: David Mandelberg via GitGitGadget <gitgitgadget@gmail•com>,
git@vger•kernel.org, Jacob Keller <jacob.keller@gmail•com>
Subject: Re: [PATCH v3 2/2] completion: fix bugs with slashes in remote names
Date: Tue, 18 Mar 2025 17:02:03 +0000 [thread overview]
Message-ID: <d6945541-c106-49a2-8072-2a4e1b8903eb@gmail.com> (raw)
In-Reply-To: <xmqq34ffdwnl.fsf@gitster.g>
On 14/03/2025 23:23, Junio C Hamano wrote:
>
> Entirely up to you. I do not plan to perform an in-detail review on
> the topic (I do not consider myself quite qualified), but others who
> saw earlier rounds of the patch may want to say "now this is perfect"
> or "now this is perfect with this and that changes", and if you do not
> think the differenes between v3 and your upcoming v4 are small enough,
> it may be more efficient to wait for a bit to collect more comments.
I'm not an expert on our completion script but from a general shell
scripting perspective this version looks fine to me.
Best Wishes
Phillip
next prev parent reply other threads:[~2025-03-18 17:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-02 7:45 [PATCH 0/3] completion: fix bugs with slashes in remote names David Mandelberg via GitGitGadget
2025-03-02 7:45 ` [PATCH 1/3] completion: add helper to escape strings for fnmatch David Mandelberg via GitGitGadget
2025-03-02 7:45 ` [PATCH 2/3] completion: add helper to count path components David Mandelberg via GitGitGadget
2025-03-02 7:45 ` [PATCH 3/3] completion: fix bugs with slashes in remote names David Mandelberg via GitGitGadget
2025-03-02 14:17 ` Phillip Wood
2025-03-02 20:34 ` David Mandelberg
2025-03-03 16:36 ` phillip.wood123
2025-03-03 19:19 ` David Mandelberg
2025-03-03 19:43 ` Todd Zullinger
2025-03-06 20:26 ` D. Ben Knoble
2025-03-06 20:24 ` D. Ben Knoble
2025-03-06 20:38 ` Junio C Hamano
2025-03-07 10:34 ` phillip.wood123
2025-03-07 21:46 ` David Mandelberg
2025-03-13 17:40 ` D. Ben Knoble
2025-03-13 20:19 ` David Mandelberg
2025-03-03 20:29 ` Junio C Hamano
2025-03-03 19:33 ` SZEDER Gábor
2025-03-03 19:49 ` David Mandelberg
2025-03-06 20:46 ` Junio C Hamano
2025-03-07 20:11 ` David Mandelberg
2025-03-07 20:57 ` Junio C Hamano
2025-03-07 21:38 ` David Mandelberg
2025-03-07 21:45 ` Junio C Hamano
2025-03-05 0:07 ` [PATCH v2 0/2] " David Mandelberg
2025-03-05 0:08 ` [PATCH v2 1/2] completion: add helper to count path components David Mandelberg
2025-03-05 0:09 ` [PATCH v2 2/2] completion: fix bugs with slashes in remote names David Mandelberg
2025-03-05 20:50 ` David Mandelberg
2025-03-06 16:35 ` Phillip Wood
2025-03-06 17:12 ` David Mandelberg
2025-03-06 17:39 ` Phillip Wood
2025-03-14 19:40 ` [PATCH v3 0/2] " David Mandelberg
2025-03-14 19:41 ` [PATCH v3 1/2] completion: add helper to count path components David Mandelberg
2025-03-14 19:43 ` [PATCH v3 2/2] completion: fix bugs with slashes in remote names David Mandelberg
2025-03-14 22:18 ` Junio C Hamano
2025-03-14 22:37 ` David Mandelberg
2025-03-14 23:23 ` Junio C Hamano
2025-03-18 17:02 ` Phillip Wood [this message]
2025-03-18 17:27 ` Junio C Hamano
2025-03-23 21:04 ` [PATCH v4 0/2] " David Mandelberg
2025-03-23 21:05 ` [PATCH v4 1/2] completion: add helper to count path components David Mandelberg
2025-03-23 21:06 ` [PATCH v4 2/2] completion: fix bugs with slashes in remote names David Mandelberg
2025-04-08 14:18 ` [PATCH v4 0/2] " Phillip Wood
2025-04-08 18:55 ` David Mandelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6945541-c106-49a2-8072-2a4e1b8903eb@gmail.com \
--to=phillip.wood123@gmail$(echo .)com \
--cc=david@mandelberg$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitgitgadget@gmail$(echo .)com \
--cc=gitster@pobox$(echo .)com \
--cc=jacob.keller@gmail$(echo .)com \
--cc=phillip.wood@dunelm$(echo .)org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox