Subject: Re: [PATCH 12/12] attr: enable incomplete-line whitespace error for this project

From: Phillip Wood <[email-masked]>
Date: Mon, 10 Nov 2025 14:55:32 +0000

On 04/11/2025 02:09, Junio C Hamano wrote:
> Now "git diff --check" and "git apply --whitespace=warn/fix" learned
> incomplete line is a whitespace error, enable them for this project
> to prevent patches to add new incomplete lines to our sources.

Makes sense

> -*.[ch] whitespace=indent,trail,space diff=cpp
> -*.sh whitespace=indent,trail,space text eol=lf
> +*.[ch] whitespace=indent,trail,space,incomplete diff=cpp
> +*.sh whitespace=indent,trail,space,incomplete text eol=lf

Do we want to check for incomplete lines in our documentation files as 
well? This series does not update WS_DEFAULT_RULE to include 
WS_INCOMPLETE_LINE so we will not detect incomplete lines unless we set 
an attribute.

Thanks

Phillip

>   *.perl text eol=lf diff=perl
>   *.pl text eof=lf diff=perl
>   *.pm text eol=lf diff=perl