From: Jakub Narebski <jnareb@gmail•com>
To: git@vger•kernel.org
Subject: Re: [idea] Converting sha1 evaluator into parser/interpreter
Date: Sun, 21 May 2006 12:13:50 +0200 [thread overview]
Message-ID: <e4peg7$g3b$1@sea.gmane.org> (raw)
In-Reply-To: e4p71u$t0s$1@sea.gmane.org
Jakub Narebski wrote:
> Shawn Pearce wrote:
>
>> There was just a short conversation on #git about converting
>> the sha1 expression evaluator into a split parser/interpreter
>> model. The idea here would be to convert an expression such as
>>
>> HEAD@{yesterday}~3^{tree}
>>
>> into a an expression tree such as (in LISP style):
>>
>> (peel-onion (walk-back 3 (date-spec yesterday (ref HEAD))))
>>
>> with such a tree it is relatively easy to evaluate the expression,
>> but its also easy to determine if a ref name is valid. Just pass
>> it through the parser and see if you get back anything more complex
>> then '(ref <input>)'.
>
> Didn't you meant to see if we get correct tree (not a forest),
> and if the root of said tree is '(ref <commit-ish>)' [1]?
I'm sorry. Of course branch names (ref names) should be limited to the ones
that doesn't make problems for the parser, i.e. they should parse to single
element parse tree:
<input> ---parses to---> (ref <input>)
and doesn't give problems for other parsers (e.g.commit list parser
including '^A B' and 'A..B'; remotes branch mapping parser 'srcref:destref'
and '+srcref:destref') and shell (e.g. globbing).
P.S. Hmmm... is '--' branch name (heads/--) possible?
P.P.S. Would branch name which include '!' and/or '$' cause trouble?
--
Jakub Narebski
Warsaw, Poland
prev parent reply other threads:[~2006-05-21 10:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-21 8:06 [idea] Converting sha1 evaluator into parser/interpreter Jakub Narebski
2006-05-21 10:13 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='e4peg7$g3b$1@sea.gmane.org' \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox