Subject: Re: [PATCH] gitweb: Support for snapshot

From: Jakub Narebski <[email-masked]>
Date: Sat, 19 Aug 2006 13:09:34 +0200

Junio C Hamano wrote:

> +sub feature_snapshot {
> +       my ($ctype, $suffix, $command) = @_;
> +       my ($val) = git_get_project_config('snapshot');
> +       if ($val eq 'gzip') { return ('gzip', 'gz'); }
> +       elsif ($val eq 'bzip2') { return ('bzip2', 'bz2'); }
> +       elsif ($val eq 'none') { return (); }
> +
> +       return ($ctype, $suffix, $command);
> +}

Should it be ('x-gzip', 'gzip', 'gz') and ('x-bzip2', 'bzip2', 'bz2'),
i.e. with $ctype first?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git