Subject: Re: [PATCH 00/19] gitweb: Remove dependency on external diff and need for temporary files

From: Jakub Narebski <[email-masked]>
Date: Sun, 27 Aug 2006 17:37:29 +0200

Linus Torvalds wrote:

> On Fri, 25 Aug 2006, Jakub Narebski wrote:
>>
>> This series of patches (now finished) removes dependency on
>> external diff (/usr/bin/diff) to produce commitdiff and blobdiff
>> views, and the need for temporary files.
> 
> Ok, can we now please fix my final annoyance, which is that gitweb from 
> the very beginning has apparently believed that the "Signed-off-by:" etc 
> lines are not important, and they get stripped away when looking at the 
> "commit-diff".

This can be easily fixed.

> Also, "commit-diff" really should have some minimal authorship 
> information. It's silly to have to go to "commit" and then separately ask 
> for "diff" to see all these very basic things.

And this need some layout redesign for commitdiff and log views.
Currently it is specially formatted subject/first line, simplified
message (with empty lines collapsed), and without signoff.

Perhaps something similar to what "log" view uses?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git