From: "René Scharfe" <l.s.r@web•de>
To: Patrick Steinhardt <ps@pks•im>
Cc: Git List <git@vger•kernel.org>
Subject: Re: [PATCH] xdiff-interface: stop using the_repository
Date: Mon, 9 Feb 2026 15:14:33 +0100 [thread overview]
Message-ID: <ee549683-1c80-4a9b-83b4-a44fafb1a47f@web.de> (raw)
In-Reply-To: <aYmtab_uqMZBygAG@pks.im>
On 2/9/26 10:48 AM, Patrick Steinhardt wrote:
> On Sun, Feb 08, 2026 at 02:47:40PM +0100, René Scharfe wrote:
>> diff --git a/xdiff-interface.c b/xdiff-interface.c
>> index 1a35556380..cd7493730b 100644
>> --- a/xdiff-interface.c
>> +++ b/xdiff-interface.c
>> @@ -7,6 +6,7 @@
>> #include "config.h"
>> #include "hex.h"
>> #include "odb.h"
>> +#include "repository.h"
>> #include "strbuf.h"
>> #include "xdiff-interface.h"
>> #include "xdiff/xtypes.h"
>
> It's a bit surprising that we have to add this include, but I assume
> that we use a function that's declared in this file?
Good point, we don't actually need it. It's left over from an earlier
version that had a struct repository pointer as new parameter. :-|
René
next prev parent reply other threads:[~2026-02-09 14:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 13:47 [PATCH] xdiff-interface: stop using the_repository René Scharfe
2026-02-09 9:48 ` Patrick Steinhardt
2026-02-09 14:14 ` René Scharfe [this message]
2026-02-09 11:15 ` Junio C Hamano
2026-02-09 15:21 ` René Scharfe
2026-02-09 17:45 ` Junio C Hamano
2026-02-09 19:24 ` René Scharfe
2026-02-09 18:57 ` Elijah Newren
2026-02-09 20:01 ` Junio C Hamano
2026-02-15 18:42 ` René Scharfe
2026-02-15 18:42 ` René Scharfe
2026-02-09 19:24 ` [PATCH v2] " René Scharfe
2026-02-10 13:28 ` Patrick Steinhardt
2026-02-10 21:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee549683-1c80-4a9b-83b4-a44fafb1a47f@web.de \
--to=l.s.r@web$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox