From: Colin Stagner <ask+git@howdoi•land>
To: Junio C Hamano <gitster@pobox•com>, git@vger•kernel.org
Cc: Patrick Steinhardt <ps@pks•im>,
Patrik Weiskircher <patrik@pspdfkit•com>,
Adam Dinwoodie <adam@dinwoodie•org>
Subject: Re: Re* [RFH] adding test coverage for contrib/ in CI jobs
Date: Thu, 5 Feb 2026 00:05:59 -0600 [thread overview]
Message-ID: <ef128e1d-dd3e-4573-bfcd-6a98a0a1f394@howdoi.land> (raw)
In-Reply-To: <xmqqjywtu58j.fsf_-_@gitster.g>
Junio C Hamano <gitster@pobox•com> writes:
> Unfortunately, this seems to reveal existing other problems with
> subtree tests (t7900), in addition to diff-highlight tests (t9400)
> in various configurations.
>
> https://github.com/git/git/actions/runs/21617099884
>
> This Ci run is near the tip of 'seen', so there may be breakages
> attributable to new topics in flight
At least some of the subtree failures on linux-reftable, such as
<https://github.com/git/git/actions/runs/21617099884/job/62298228602#step:10:421>
are actually due to a bug in ubuntu:rolling's "dirname" implementation.
This was fixed upstream in late January [1].
bug behavior demo:
podman run --rm -it -q docker.io/library/ubuntu:questing-20251217 \
dirname whatever/.
outputs "whatever"
podman run --rm -it -q docker.io/library/ubuntu:25.10 \
dirname whatever/.
outputs "."
subtree has an up-front call to
dir="$(dirname "$arg_prefix/.")"
which encounters the defect. It then attempts to do things like
git read-tree --prefix=. $someref
that error out with messages like "error: invalid path './sub1'"
[1]: https://github.com/uutils/coreutils/issues/10508
next prev parent reply other threads:[~2026-02-05 6:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 12:09 [PATCH] subtree: validate --prefix against commit in split Pushkar Singh
2026-01-15 12:24 ` [PATCH v2] " Pushkar Singh
2026-01-15 16:30 ` Junio C Hamano
2026-01-15 17:52 ` [PATCH v3] " Pushkar Singh
2026-02-02 18:54 ` Josh Steadmon
2026-02-02 19:10 ` Junio C Hamano
2026-02-02 21:07 ` Junio C Hamano
2026-02-03 15:30 ` [RFH] adding test coverage for contrib/ in CI jobs Junio C Hamano
2026-02-03 17:06 ` Re* " Junio C Hamano
2026-02-03 23:09 ` Junio C Hamano
2026-02-04 4:38 ` Colin Stagner
2026-02-04 19:55 ` Junio C Hamano
2026-02-05 6:05 ` Colin Stagner [this message]
2026-02-05 16:39 ` Junio C Hamano
2026-02-05 20:54 ` Junio C Hamano
2026-02-03 21:26 ` Junio C Hamano
2026-02-03 21:53 ` Jeff King
2026-02-03 16:48 ` [PATCH v4] subtree: validate --prefix against commit in split Pushkar Singh
2026-02-03 17:37 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef128e1d-dd3e-4573-bfcd-6a98a0a1f394@howdoi.land \
--to=ask+git@howdoi$(echo .)land \
--cc=adam@dinwoodie$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=patrik@pspdfkit$(echo .)com \
--cc=ps@pks$(echo .)im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox