From: Jakub Narebski <jnareb@gmail•com>
To: git@vger•kernel.org
Subject: Re: [PATCH] gitweb: Show project README if available
Date: Tue, 10 Oct 2006 11:00:41 +0200 [thread overview]
Message-ID: <egfndo$lg6$1@sea.gmane.org> (raw)
In-Reply-To: 20061010025627.19317.70511.stgit@rover
Petr Baudis wrote:
> + print $_ while (<$fd>);
Wouldn't it be better to do it in slurp mode, i.e.
{
local $/
print <$fd>;
}
instead?
Do you assume that README is HTML fragment? If not, you should esc_html it.
Besides, we have similar (if assumed to have one line only) file, namely
description.
Besides, README for a project can be huge. Git README has 589 lines!
--
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git
next prev parent reply other threads:[~2006-10-10 9:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-10 2:56 [PATCH] gitweb: Show project README if available Petr Baudis
2006-10-10 3:20 ` Junio C Hamano
2006-10-10 4:33 ` Junio C Hamano
2006-10-10 10:55 ` Petr Baudis
2006-10-10 11:21 ` Jakub Narebski
2006-10-10 14:25 ` Horst H. von Brand
2006-10-10 5:15 ` Luben Tuikov
2006-10-10 8:33 ` Andreas Ericsson
2006-10-10 9:00 ` Jakub Narebski [this message]
2006-10-10 10:41 ` Petr Baudis
2006-10-11 12:23 ` Jakub Narebski
2006-10-11 18:17 ` Jeff King
2006-10-11 18:46 ` Jakub Narebski
2006-10-11 19:32 ` Junio C Hamano
2006-10-11 20:33 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='egfndo$lg6$1@sea.gmane.org' \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox