Subject: Re: git-shortlog mailmap

From: Jakub Narebski <[email-masked]>
Date: Thu, 26 Oct 2006 15:13:40 +0200

Andreas Ericsson wrote:

> Jakub Narebski wrote:
>> Petr Baudis wrote:
>>>
>>> Dear diary, on Thu, Oct 26, 2006 at 11:25:50AM CEST, I got a letter
>>> where Jakub Narebski <[email-masked]> said that...
>>>>
>>>> BTW. both Perl version and builtin shorlog have email->real name translation
>>>> table built in. In Perl script version it is in __DATA__ section, and we
>>>> could update it using Inline::Files module, in C version it was in table.
>>>> But in fact this list is project specific. Shouldn't we make it customizable
>>>> (::sigh::, yet another file in $GIT_DIR...).
>>>>
>>> I really dislike the fact that we _do_ this mapping at all, this seems
>>> so much a totally wrong point at which to do it. The information tracked
>>> in Git is still wrong and all the tools except shortlog still display it
>>> wrong - why should shortlog in particular be special? Why don't we do
>>> this at the git-am time instead?
>> 
>> Because git-shortlog has to deal also with _historical_ data, which caused
>> one way or the other to have only email and not realname recorded. So till
>> history gets rewritteen, and tags resigned, git-shortlog has to do the
>> mapping to have meaningfull output.
> 
> Wouldn't this be better implemented in the rev-list code then, so all 
> log viewers can benefit from it?

Because this belongs to porcelain. Plumbing shouldn't show something
that isn't there.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git