From: Jari Aalto <jari.aalto@cante•net>
To: git@vger•kernel.org
Subject: [PATCH] On error, do not list all commands, but point to --help option
Date: Sun, 21 Oct 2007 01:41:41 +0300 [thread overview]
Message-ID: <ir51if2y.fsf@blue.sea.net> (raw)
In-Reply-To: bqaujirk.fsf@blue.sea.net
- Remove out call to list_common_cmds_help()
- Send error message to stderr, not stdout.
Signed-off-by: Jari Aalto <jari.aalto@cante•net>
---
help.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/help.c b/help.c
index 1cd33ec..814a8cd 100644
--- a/help.c
+++ b/help.c
@@ -185,8 +185,7 @@ static void show_man_page(const char *git_cmd)
void help_unknown_cmd(const char *cmd)
{
- printf("git: '%s' is not a git-command\n\n", cmd);
- list_common_cmds_help();
+ fprintf(stderr, "git: '%s' is not a git-command. See --help\n\n", cmd);
exit(1);
}
--
1.5.3.2.81.g17ed
next prev parent reply other threads:[~2007-10-21 3:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-20 8:24 [PATCH] On error, do not list all commands, but point to --help option Jari Aalto
2007-10-20 20:28 ` Johannes Schindelin
2007-10-20 22:28 ` Jari Aalto
2007-10-20 23:02 ` Johannes Schindelin
2007-10-21 2:06 ` Shawn O. Pearce
2007-10-21 3:24 ` Jeff King
2007-10-21 3:29 ` Shawn O. Pearce
2007-10-21 6:33 ` Yin Ping
2007-10-21 8:58 ` Wincent Colaiuta
2007-10-21 12:42 ` Andreas Ericsson
2007-10-21 13:13 ` Jan Hudec
2007-10-21 14:17 ` Andreas Ericsson
2007-10-24 0:28 ` Salikh Zakirov
2007-10-20 22:41 ` Jari Aalto [this message]
2007-10-21 3:33 ` Shawn O. Pearce
2007-10-21 10:09 ` Jan Hudec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ir51if2y.fsf@blue.sea.net \
--to=jari.aalto@cante$(echo .)net \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox