public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed
From: Stefan Monnier <monnier@iro•umontreal.ca>
To: git@vger•kernel.org
Subject: Re: [BUG] Destructive access to an "objects/info/alternates" repository
Date: Mon, 04 Jan 2021 15:47:53 -0500	[thread overview]
Message-ID: <jwvlfd81le8.fsf-monnier+gmane.comp.version-control.git@gnu.org> (raw)
In-Reply-To: 20210104135410.myjaygaulqnxcnsc@chatter.i7.local

Konstantin Ryabitsev [2021-01-04 08:54:10] wrote:
> I would guess that this is happening in builtin/gc.c#686 [1], where it calls
> clean_pack_garbage(). Running "git count-objects -v" shows:
>
> $ git count-objects -v
> warning: no corresponding .pack:
> /tmp/test/nongnu/.git/objects/pack/pack-0d85e74ac2f7e51ce26f281e64eb738e8182fa95.idx
> warning: no corresponding .pack:
> /tmp/test/nongnu/.git/objects/pack/pack-5fe14feff49ccdee5469af9dc94f6784e8464a6b.idx
> count: 0
> size: 0
> in-pack: 0
> packs: 0
> size-pack: 0
> prune-packable: 0
> garbage: 2
> size-garbage: 6573
> alternate: /tmp/test/nongnu/.git/objects

Ah, that'd make sense, yes.

> I agree with Stefan that this is undesired behaviour, even when it only
> happens when attempting to clean up garbage -- git-gc (and git-count-objects)
> should distinguish between garbage in the parent repository and its own
> repository and not attempt any modification of the parent repository during
> gc or any other operation.

Great, so IIUC:
- this is a harmless warning
- it's considered as a bug
- so my use case should work fine in practice and is not considered as
  "too weird to be supported"
Thank you,


        Stefan


  reply	other threads:[~2021-01-04 20:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-28 18:50 [BUG] Destructive access to an "objects/info/alternates" repository Stefan Monnier
2020-12-28 19:00 ` Konstantin Ryabitsev
2020-12-28 19:29   ` Stefan Monnier
2020-12-28 20:17     ` Stefan Monnier
2020-12-29 15:44       ` Konstantin Ryabitsev
2021-01-03 16:50         ` Stefan Monnier
2021-01-04 13:54           ` Konstantin Ryabitsev
2021-01-04 20:47             ` Stefan Monnier [this message]
2021-01-04 21:20               ` Konstantin Ryabitsev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvlfd81le8.fsf-monnier+gmane.comp.version-control.git@gnu.org \
    --to=monnier@iro$(echo .)umontreal.ca \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox