From: Ed Avis <eda@waniasset•com>
To: git@vger•kernel.org
Subject: Re: Build bug report: 'make check' needs sparse, but configure doesn't check it
Date: Mon, 6 Oct 2008 11:28:25 +0000 (UTC) [thread overview]
Message-ID: <loom.20081006T112601-258@post.gmane.org> (raw)
In-Reply-To: 20081006065847.GA27516@spearce.org
Shawn O. Pearce <spearce <at> spearce.org> writes:
>Nah. We're not going to rename the target to "make sparse".
Fair enough. Can I suggest a one line patch to avoid any misunderstanding in
the future?
diff --git a/Makefile b/Makefile
index 3c0664a..c98b921 100644
--- a/Makefile
+++ b/Makefile
@@ -1354,6 +1354,7 @@ check-sha1:: test-sha1$X
./test-sha1.sh
check: common-cmds.h
+ @echo "'make check' runs the 'sparse' tool on all source files; say
'make test' to run the test suite."
for i in *.c; do sparse $(ALL_CFLAGS) $(SPARSE_FLAGS) $$i || exit; done
remove-dashes:
prev parent reply other threads:[~2008-10-06 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-04 13:19 Build bug report: 'make check' needs sparse, but configure doesn't check it Ed Avis
2008-10-05 0:34 ` Dmitry Potapov
2008-10-05 9:46 ` Ed Avis
2008-10-06 6:58 ` Shawn O. Pearce
2008-10-06 11:28 ` Ed Avis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20081006T112601-258@post.gmane.org \
--to=eda@waniasset$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox