From: "Øystein Walle" <oystwa@gmail•com>
To: git@vger•kernel.org
Subject: Re: [PATCH v7 00/11] Add interpret-trailers builtin
Date: Sat, 8 Mar 2014 11:54:14 +0000 (UTC) [thread overview]
Message-ID: <loom.20140308T124447-78@post.gmane.org> (raw)
In-Reply-To: xmqq8uslu1bi.fsf@gitster.dls.corp.google.com
Junio C Hamano <gitster <at> pobox.com> writes:
>
> ...
>
> is easier to read and maintain if written like so (with using HT
> properly---our MUAs may damage it and turn the indentation into
> spaces):
>
> ... &&
> sed -e "s/ Z$/ /" >>expect <<-\EOF &&
> Fixes: Z
> Acked-by= Z
> Reviewed-by: Z
> Signed-off-by: Z
> EOF
> ...
>
How about:
printf '%s: \n' Fixes Acked-by Reviewed-by Signed-off-by >> expect
This solution scores high marks in both readability and maintainability
in my mind.
next prev parent reply other threads:[~2014-03-08 11:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 22:06 [PATCH v7 00/11] Add interpret-trailers builtin Christian Couder
2014-03-07 21:49 ` Junio C Hamano
2014-03-08 11:54 ` Øystein Walle [this message]
2014-03-10 15:27 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20140308T124447-78@post.gmane.org \
--to=oystwa@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox