From: "Øystein Walle" <oystwa@gmail•com>
To: git@vger•kernel.org
Subject: Re: [PATCH v4] completion: ignore chpwd_functions when cding on zsh
Date: Thu, 16 Oct 2014 18:10:14 +0000 (UTC) [thread overview]
Message-ID: <loom.20141016T200635-928@post.gmane.org> (raw)
In-Reply-To: CAMUzdXkWNxW8Py6ATwtvqJ7s75dsP8vz6gMjk6tQa6gTGvcdWw@mail.gmail.com
Brandon Turner <bt <at> brandonturner.net> writes:
>
> On Thu, Oct 9, 2014 at 5:11 PM, Junio C Hamano <gitster <at> pobox.com> wrote:
> > Actually the patch was slightly wrong. It did not quite matter as
> > "cd ''" is a no-op, but "git -C '' cmd" is not that lenient (which
> > may be something we may want to fix) and breaks t9902 by exposing
> > an existing breakage in the callchain.
> >
> > Here is a replacement.
>
> I did some more testing on this iteration as well - looks good.
>
Sorry, for the late reply, guys...
I've tested it too and it seems to work just fine.
As for my comments about using $=2 instead of $2: When zsh runs through
this code it does so while emulating ksh. Thus the reliance on splitting
unquoted expansions is not a problem. I was unaware of this until ten
minutes ago.
Øsse
next prev parent reply other threads:[~2014-10-16 18:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 3:53 [PATCH] completion: ignore chpwd_functions when cding Brandon Turner
2014-10-08 18:12 ` Junio C Hamano
2014-10-08 21:49 ` [PATCH v2] " Brandon Turner
2014-10-08 21:49 ` [PATCH v3] completion: ignore chpwd_functions when cding on zsh Brandon Turner
2014-10-09 7:34 ` Øystein Walle
2014-10-09 18:10 ` Junio C Hamano
2014-10-09 19:01 ` [PATCH v4] " Brandon Turner
2014-10-09 19:47 ` Øystein Walle
2014-10-09 20:01 ` Junio C Hamano
2014-10-09 20:45 ` Junio C Hamano
2014-10-09 22:04 ` Brandon Turner
2014-10-09 22:11 ` Junio C Hamano
2014-10-09 22:30 ` Brandon Turner
2014-10-16 18:10 ` Øystein Walle [this message]
2014-10-09 19:21 ` [PATCH v3] " Øystein Walle
2014-10-08 21:50 ` [PATCH] completion: ignore chpwd_functions when cding Brandon Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=loom.20141016T200635-928@post.gmane.org \
--to=oystwa@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox