From: Andreas Schwab <schwab@linux-m68k•org>
To: Jonathan Nieder <jrnieder@gmail•com>
Cc: Dmitry Ivankov <divanorama@gmail•com>,
git@vger•kernel.org, "Shawn O. Pearce" <spearce@spearce•org>,
David Barr <davidbarr@google•com>
Subject: Re: [PATCH v3] fast-import: do not write bad delta for replaced subtrees
Date: Sat, 20 Aug 2011 11:08:30 +0200 [thread overview]
Message-ID: <m262lspi0h.fsf@linux-m68k.org> (raw)
In-Reply-To: <20110820010901.GA2512@elie.sbx02827.chicail.wayport.net> (Jonathan Nieder's message of "Fri, 19 Aug 2011 20:09:02 -0500")
Jonathan Nieder <jrnieder@gmail•com> writes:
> Thanks again for this. Abusing (S_ISDIR | S_ISUID) still leaves a bad
> taste in my mouth, but after your description I'm convinced that
> behavior-wise it's the right thing to do.
$ git grep S_ISUID
compat/mingw.h:#define S_ISUID 0
Andreas.
--
Andreas Schwab, schwab@linux-m68k•org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
next prev parent reply other threads:[~2011-08-20 9:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 10:32 [PATCH 0/3] fix data corruption in fast-import Dmitry Ivankov
2011-08-12 10:32 ` [PATCH 1/3] fast-import: extract object preparation function Dmitry Ivankov
2011-08-12 10:32 ` [PATCH 2/3] fast-import: add a check for tree delta base sha1 Dmitry Ivankov
2011-08-13 21:02 ` Jonathan Nieder
2011-08-12 10:32 ` [PATCH 3/3] fast-import: prevent producing bad delta Dmitry Ivankov
2011-08-14 18:32 ` [PATCH v2 0/2] fix data corruption in fast-import Dmitry Ivankov
2011-08-14 18:32 ` [PATCH v2 1/2] fast-import: add a test for tree delta base corruption Dmitry Ivankov
2011-08-14 18:32 ` [PATCH v2 2/2] fast-import: prevent producing bad delta Dmitry Ivankov
2011-08-20 1:09 ` [PATCH v3] fast-import: do not write bad delta for replaced subtrees Jonathan Nieder
2011-08-20 9:08 ` Andreas Schwab [this message]
2011-08-20 15:43 ` Jonathan Nieder
2011-08-20 17:22 ` [PATCH v4] " Dmitry Ivankov
2011-08-20 17:48 ` Jonathan Nieder
2011-08-20 18:28 ` Dmitry Ivankov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m262lspi0h.fsf@linux-m68k.org \
--to=schwab@linux-m68k$(echo .)org \
--cc=davidbarr@google$(echo .)com \
--cc=divanorama@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=jrnieder@gmail$(echo .)com \
--cc=spearce@spearce$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox