From: Seth Falcon <sethfalcon@gmail•com>
To: Eric Wong <normalperson@yhbt•net>
Cc: Junio C Hamano <junkio@cox•net>,
Alexander Klink <ak-git@cynops•de>,
git@vger•kernel.org
Subject: Re: git-svn failure when symlink added in svn
Date: Mon, 30 Apr 2007 07:33:38 -0700 [thread overview]
Message-ID: <m2abwqq6d9.fsf@ziti.local> (raw)
In-Reply-To: <20070430063133.GA14414@untitled> (Eric Wong's message of "Sun, 29 Apr 2007 23:31:33 -0700")
Eric Wong <normalperson@yhbt•net> writes:
> Junio C Hamano <junkio@cox•net> wrote:
>> Eric Wong <normalperson@yhbt•net> writes:
>>
>> > Junio C Hamano <junkio@cox•net> wrote:
>> >> diff --git a/git-svn.perl b/git-svn.perl
>> >> index 4be8576..cef6697 100755
>> >> --- a/git-svn.perl
>> >> +++ b/git-svn.perl
>> >> @@ -2464,15 +2464,15 @@ sub close_file {
>> >> my $hash;
>> >> my $path = $self->git_path($fb->{path});
>> >> if (my $fh = $fb->{fh}) {
>> >> - seek($fh, 0, 0) or croak $!;
>> >> + sysseek($fh, 0, 0) or croak $!;
>> >> my $md5 = Digest::MD5->new;
>> >> $md5->addfile($fh);
>> >
>> > We may want to keep the plain seek() here and do both seek and sysseek,
>> > I'm not sure if $md5->addfile() uses read or sysread internally.
>>
>> Ok. The seek before Digest::MD5 can stay as it has been that
>> way for a long time without causing problems. How about this as
>> an replacement then?
>
> Looks good to me. Seth?
The test cases passes as does the small example I had come up with. I
also tried doing a git svn clone on a small repos and checking that
the resulting HEAD was the same as a previously created one (it was).
> If Seth is okay with it, then:
> Acked-by: Eric Wong <normalperson@yhbt•net>
Acked-by: Seth Falcon <sethfalcon@gmail•com>
+ seth
next prev parent reply other threads:[~2007-04-30 14:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-14 6:41 git-svn failure when symlink added in svn Seth Falcon
2007-04-14 20:10 ` Eric Wong
2007-04-16 3:13 ` Seth Falcon
2007-04-26 23:07 ` Alexander Klink
2007-04-27 18:03 ` Linus Torvalds
2007-04-28 13:02 ` Alexander Klink
2007-04-28 16:54 ` Seth Falcon
2007-04-28 17:31 ` Junio C Hamano
2007-04-28 18:13 ` Seth Falcon
2007-04-28 18:34 ` Junio C Hamano
2007-04-28 21:15 ` Seth Falcon
2007-04-28 22:43 ` Junio C Hamano
[not found] ` <m2irbfqlze.fsf@ziti.local>
2007-04-29 18:26 ` Eric Wong
2007-04-30 14:43 ` Seth Falcon
2007-04-30 15:43 ` Eric Wong
2007-05-01 17:49 ` Seth Falcon
2007-04-29 18:31 ` Eric Wong
2007-04-29 21:01 ` Junio C Hamano
2007-04-29 22:21 ` Eric Wong
2007-04-30 0:24 ` Alexander Klink
2007-04-30 5:08 ` Junio C Hamano
2007-04-30 6:31 ` Eric Wong
2007-04-30 14:33 ` Seth Falcon [this message]
2007-05-01 20:53 ` Alexander Klink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2abwqq6d9.fsf@ziti.local \
--to=sethfalcon@gmail$(echo .)com \
--cc=ak-git@cynops$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=junkio@cox$(echo .)net \
--cc=normalperson@yhbt$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox