From: James Cloos <cloos@jhcloos•com>
To: Nicolas Pitre <nico@cam•org>
Cc: git@vger•kernel.org
Subject: Re: [PATCH 1/1] Improve progress display in kB range.
Date: Wed, 22 Apr 2009 10:33:19 -0400 [thread overview]
Message-ID: <m34owgoj08.fsf@lugabout.jhcloos.org> (raw)
In-Reply-To: <m3d4b5oj76.fsf@lugabout.jhcloos.org> (James Cloos's message of "Tue, 21 Apr 2009 16:16:53 -0400")
|> Therefore, in practice — and as I have witnessed several thousand times
|> without ever having seen a contrary example — display_throughput() is
|> called *durring* a download only when total & 0xFFF == 0xFFF.
Another possibility is an off-by-one error. The relevant part of fill()
looks like:
,----< excerpt from index-pack.c:fill() >
| do {
| ssize_t ret = xread(input_fd, input_buffer + input_len,
| sizeof(input_buffer) - input_len);
| if (ret <= 0) {
| if (!ret)
| die("early EOF");
| die("read error on input: %s", strerror(errno));
| }
| input_len += ret;
| if (from_stdin)
| display_throughput(progress, consumed_bytes + input_len);
| } while (input_len < min);
| return input_buffer;
| }
`----
if *(input_buffer + ret) is the last read octet rather than the next
empty octet, that would also explain what I see.
Perhaps that call to display_throughput() should have an extra +1?
-JimC
--
James Cloos <cloos@jhcloos•com> OpenPGP: 1024D/ED7DAEA6
next prev parent reply other threads:[~2009-04-22 14:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 4:38 [PATCH 0/1] Improve progress display in kB range James Cloos
2009-04-19 4:32 ` [PATCH 1/1] " James Cloos
2009-04-21 4:56 ` Nicolas Pitre
2009-04-21 17:11 ` James Cloos
2009-04-21 17:28 ` Nicolas Pitre
2009-04-21 20:16 ` James Cloos
2009-04-22 14:33 ` James Cloos [this message]
2009-04-22 19:44 ` Junio C Hamano
2009-04-22 22:35 ` James Cloos
2009-04-23 6:23 ` Johannes Sixt
2009-04-24 20:15 ` James Cloos
2009-04-24 21:46 ` Nicolas Pitre
2009-04-24 22:20 ` James Cloos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m34owgoj08.fsf@lugabout.jhcloos.org \
--to=cloos@jhcloos$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=nico@cam$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox