Subject: Re: [PATCH] diff and apply: fix singular/plural grammar nit.

From: Jakub Narebski <[email-masked]>
Date: Sun, 27 Nov 2011 06:47:21 -0800 (PST)

David Ripton <[email-masked]> writes:

> Remove the trailing 's' from "files", "insertions", and "deletions"
> when there is only one of the item.
> 
> Signed-off-by: David Ripton <[email-masked]>
> ---
[...]
> -       printf(" %d files changed, %d insertions(+), %d
> deletions(-)\n", files, adds, dels);

Whitespace damaged.  Please turn off word wrapping (limiting line
width) when sending patches.

> +       printf(" %d file%s changed, %d insertion%s(+), %d deletion%s(-)\n",
> +              files, (files == 1 ? "" : "s"),
> +              adds, (adds == 1 ? "" : "s"),
> +              dels, (dels == 1 ? "" : "s"));
>   }

First, I think this is an API / plumbing and should not be changed.
But I might be mistaken about that.

Second, it is a perfect example ho to *not* handle plural form in the
presence of internationalization (i18n) efforts.  See e.g.

  http://www.gnu.org/s/hello/manual/gettext/Plural-forms.html

-- 
Jakub Narębski