From: Orivej Desh <orivej@gmx•fr>
To: git@vger•kernel.org
Subject: SVN.pm produces "Wide character in setenv" warnings
Date: Thu, 19 Feb 2015 06:49:45 +0000 [thread overview]
Message-ID: <m3h9ui4cqe.fsf@gmx.fr> (raw)
[-- Attachment #1: Type: text/plain, Size: 433 bytes --]
"git svn fetch" causes Perl 5.18 or newer to emit "Wide character in
setenv" warnings when used in combination with svn.authorsfile with
non-ASCII names:
Wide character in setenv at /usr/lib64/perl5/vendor_perl/5.20.1/Git/SVN.pm line 969.
Wide character in setenv at /usr/lib64/perl5/vendor_perl/5.20.1/Git/SVN.pm line 973.
I have no taste of Perl so I do not propose this patch for inclusion,
but it fixes this for me.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: git-svn-env.patch --]
[-- Type: text/x-diff, Size: 1016 bytes --]
diff --git a/perl/Git/SVN.pm b/perl/Git/SVN.pm
index d9a52a5..2ffebfe 100644
--- a/perl/Git/SVN.pm
+++ b/perl/Git/SVN.pm
@@ -957,6 +957,17 @@ sub full_pushurl {
}
}
+sub utf8_encode {
+ my ($s) = @_;
+ utf8::encode($s);
+ return $s;
+}
+
+sub UENV {
+ my ($var, $val) = @_;
+ $ENV{$var} = utf8_encode($val);
+}
+
sub set_commit_header_env {
my ($log_entry) = @_;
my %env;
@@ -966,13 +977,13 @@ sub set_commit_header_env {
}
}
- $ENV{GIT_AUTHOR_NAME} = $log_entry->{name};
+ UENV("GIT_AUTHOR_NAME", $log_entry->{name});
$ENV{GIT_AUTHOR_EMAIL} = $log_entry->{email};
$ENV{GIT_AUTHOR_DATE} = $ENV{GIT_COMMITTER_DATE} = $log_entry->{date};
- $ENV{GIT_COMMITTER_NAME} = (defined $log_entry->{commit_name})
+ UENV("GIT_COMMITTER_NAME", (defined $log_entry->{commit_name})
? $log_entry->{commit_name}
- : $log_entry->{name};
+ : $log_entry->{name});
$ENV{GIT_COMMITTER_EMAIL} = (defined $log_entry->{commit_email})
? $log_entry->{commit_email}
: $log_entry->{email};
reply other threads:[~2015-02-19 6:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3h9ui4cqe.fsf@gmx.fr \
--to=orivej@gmx$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox