Subject: Re: [PATCH RFC 0/5] Patches to avoid reporting conversion changes.

From: Jakub Narebski <[email-masked]>
Date: Sat, 17 Apr 2010 15:32:28 -0700 (PDT)

Sverre Rabbelier <[email-masked]> writes:
> On Sat, Apr 17, 2010 at 21:34, Randal L. Schwartz <[email-masked]> wrote:

> > Yes, once it's already *in* the program.  But I bet you had to *look
> > them up* to add them.
> 
> Yes, but once they're there nobody has to look them up. It's moving
> the problem from having to look up what it means on _and_ write, to
> just write.

We use idiomatic C, e.g.

  if (!strcmp(option, "warn")) {

not

  if (strcmp(option, "warn") == 0) {

We use idiomatic Perl, e.g.

  %hash = map { $_ => 1 } @list;

not

  use English qw(-no_match_vars);

  %hash = map { $ARG => 1 } @list;

-- 
Jakub Narebski
Poland
ShadeHawk on #git