Subject: Re: [PATCH] Add testcase for 'git cvsexportcommit -w $cvsdir ...' with relative $GIT_DIR

From: Jakub Narebski <[email-masked]>
Date: Wed, 13 Feb 2008 01:26:57 -0800 (PST)

Junio C Hamano <[email-masked]> writes:

> Except that I'll reorder the patches so that
> 
>  (1) this test comes first, but with test_expect_failure instead;
> 
>  (2) then your earlier fix patch, but with a change that changes
>      the test_expect_failure to test_expect_success.
> 
> Thanks.
> 
> Perhaps it would be a good idea to require fix-up patches to
> always come with a test case to prevent future regression.

Perhaps we should add this hint to SubmittingPatches, on top
of your additions? And to t/README?

-- 
Jakub Narebski
Poland
ShadeHawk on #git