Subject: Re: [PATCH 3/3] grep: get rid of useless x < 0 comparison on an enum member

From: Andreas Schwab <[email-masked]>
Date: Mon, 07 Nov 2011 14:12:28 +0100

Ævar Arnfjörð Bjarmason <[email-masked]> writes:

> I.e. we'll always have GREP_HEADER_AUTHOR = 0 and
> GREP_HEADER_COMMITTER = 1, we'll never have GREP_HEADER_AUTHOR = and
> GREP_HEADER_COMMITTER = <some int>.

That is irrelevant.  You can always assign -1 to an object of enumerated
type and the implicit conversion to the underlying type is fully
defined, no matter what type the compiler choses.

Andreas.

-- 
Andreas Schwab, [email-masked]
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."