Subject: Re: [PATCH 5/9] gitweb: add a get function to compliment print_local_time

From: Jakub Narebski <[email-masked]>
Date: Sat, 23 Jan 2010 03:13:10 -0800 (PST)

"John 'Warthog9' Hawley" <[email-masked]> writes:

Should authorship be associated with eaglescrag.net or kernel.org?

> This adds a get function for print_local_time so that the basic
> function can be used outside of their straight printing operation.

Signoff?
> ---
>  gitweb/gitweb.perl |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index b41bc33..d38aad6 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -3537,14 +3537,21 @@ sub git_print_header_div {
>  }
>  
>  sub print_local_time {
> +	print get_local_time(@_);
> +}
> +
> +sub get_local_time {

This new function should be rather named 'format_local_time', to
follow gitweb convention of naming subroutines.  (And of course commit
message needs to be changed accordingly.)

This comment applies also to the following patch.

> +	my $localtime = "";
>  	my %date = @_;
>  	if ($date{'hour_local'} < 6) {
> -		printf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
> +		$localtime .= sprintf(" (<span class=\"atnight\">%02d:%02d</span> %s)",
>  			$date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>  	} else {
> -		printf(" (%02d:%02d %s)",
> +		$localtime .= sprintf(" (%02d:%02d %s)",
>  			$date{'hour_local'}, $date{'minute_local'}, $date{'tz_local'});
>  	}
> +
> +	return $localtime

Style (terminate statement with ';'): 

  +	return $localtime;

>  }
>  
>  # Outputs the author name and date in long form
> -- 
> 1.6.5.2
> 

-- 
Jakub Narebski
Poland
ShadeHawk on #git