From: Jakub Narebski <jnareb@gmail•com>
To: Florian La Roche <laroche@redhat•com>
Cc: git@vger•kernel.org
Subject: Re: [PATCH] gitweb: Change feeds from commit to commitdiff output.
Date: Fri, 11 Jan 2008 03:12:03 -0800 (PST) [thread overview]
Message-ID: <m3sl14mxat.fsf@roke.D-201> (raw)
In-Reply-To: <20080110130900.GA9395@dudweiler.stuttgart.redhat.com>
Florian La Roche <laroche@redhat•com> writes:
> [PATCH] gitweb: Change feeds from commit to commitdiff output.
>
> Change feeds from displaying the commit to displaying the commitdiff
> output. This way the patches are shown directly and code review is
> done more easily via watching feeds.
First, this changes _link_, and not display (change summary), so the
commit message IMHO should read rather:
gitweb: Change feeds link from commit view to commitdiff view.
Change feed link from link to commit view to link to commitdiff
view. This way the patches are shown directly and code review is
done more easily via watching feeds.
I personally do not use gitweb feeds not feed readers, so I cannot say
if this change truly helps. I just don't know what the "feed watcher"
workflow looks like.
Second, at least for Atom format it is possible to give both 'commit'
and 'commitdiff' view links as alternate links for a feed. That is
something to consider.
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -5566,7 +5566,7 @@ XML
> or next;
>
> # print element (entry, item)
> - my $co_url = href(-full=>1, action=>"commit", hash=>$commit);
> + my $co_url = href(-full=>1, action=>"commitdiff", hash=>$commit);
> if ($format eq 'rss') {
--
Jakub Narebski
Poland
ShadeHawk on #git
prev parent reply other threads:[~2008-01-11 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 13:09 [PATCH] gitweb: Change feeds from commit to commitdiff output Florian La Roche
2008-01-10 20:21 ` Junio C Hamano
2008-01-11 6:53 ` Florian La Roche
2008-01-11 11:12 ` Jakub Narebski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3sl14mxat.fsf@roke.D-201 \
--to=jnareb@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=laroche@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox