Subject: Re: [PATCH 1/3] gitweb: add extensions to highlight feature

From: Jakub Narebski <[email-masked]>
Date: Thu, 16 Dec 2010 14:22:37 -0800 (PST)

Sylvain Rabot <[email-masked]> writes:

> added: sql, php5, phps, bash, zsh, mk
> 

There is one issue with this patch (see below), but otherwise I like
it.

> Signed-off-by: Sylvain Rabot <[email-masked]>
> ---
>  gitweb/gitweb.perl |    7 ++++---
>  1 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index d521c93..db18d06 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
> @@ -250,13 +250,14 @@ our %highlight_ext = (
>  	# main extensions, defining name of syntax;
>  	# see files in /usr/share/highlight/langDefs/ directory
>  	map { $_ => $_ }
> -		qw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl),
> +		qw(py c cpp rb java css php pl js tex bib xml awk bat ini spec tcl sql),

Why did you remove 'sh' => 'sh' mapping?  Shouldn't it be

  -		qw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl),
  +		qw(py c cpp rb java css php sh pl js tex bib xml awk bat ini spec tcl sql),

>  	# alternate extensions, see /etc/highlight/filetypes.conf
>  	'h' => 'c',
> +	map { $_ => 'sh'  } qw(bash zsh),

Good idea.

>  	map { $_ => 'cpp' } qw(cxx c++ cc),
> -	map { $_ => 'php' } qw(php3 php4),
> +	map { $_ => 'php' } qw(php3 php4 php5 phps),

Good idea.

>  	map { $_ => 'pl'  } qw(perl pm), # perhaps also 'cgi'
> -	'mak' => 'make',
> +	map { $_ => 'make'} qw(mak mk),

Good idea.

Sidenote: git itself uses *.mak extension.  Is *.mk popular?

>  	map { $_ => 'xml' } qw(xhtml html htm),
>  );
>  
> -- 
> 1.7.3.2
> 

-- 
Jakub Narebski
Poland
ShadeHawk on #git