From: Pratyush Yadav <me@yadavpratyush•com>
To: Mark Levedahl <mlevedahl@gmail•com>
Cc: Junio C Hamano <gitster@pobox•com>,
mdl123@verizon•net, git@vger•kernel.org, adam@dinwoodie•org,
me@yadavpratyush•com, johannes.schindelin@gmx•de,
sunshine@sunshineco•com
Subject: Re: [PATCH v1 0/4] Remove obsolete Cygwin support from git-gui
Date: Thu, 24 Aug 2023 17:54:13 +0200 [thread overview]
Message-ID: <mafs01qfse8re.fsf@amazon.de> (raw)
In-Reply-To: <07677f17-be9b-dc46-d204-6fe46d46ebc0@gmail.com> (Mark Levedahl's message of "Sat, 5 Aug 2023 10:47:57 -0400")
On Sat, Aug 05 2023, Mark Levedahl wrote:
> On 6/27/23 13:52, Junio C Hamano wrote:
>> Mark Levedahl <mlevedahl@gmail•com> writes:
>>
>>> === This is an update, incorporating responses to Junio's and Eric's
>>> comments:
>>> -- clarified what the "upstream" git-gui branch is
>>> -- Removed some changes from patch 2 as requested by Junio, reducing
>>> changes in patch 3 and patch 4
>>> All code is fixed only after applying patch 4
>>> Differences in patch 3 and 4 are minimimized
>>> -- updated comments to clarify G4w dedicated code.
>>> -- updated all comments to (hopefully) clarify points of confusion
>>> ===
>>> ...
>>> Mark Levedahl (4):
>>> git gui Makefile - remove Cygwin modifications
>>> git-gui - remove obsolete Cygwin specific code
>>> git-gui - use cygstart to browse on Cygwin
>>> git-gui - use mkshortcut on Cygwin
>>>
>>> Makefile | 21 +------
>>> git-gui.sh | 118 +++-----------------------------------
>>> lib/choose_repository.tcl | 27 +--------
>>> lib/shortcut.tcl | 31 +++++-----
>>> 4 files changed, 27 insertions(+), 170 deletions(-)
>> OK, Dscho says v1 looks good, and I have no further comments.
>>
>> Pratyush, can I expect that you take further comments and usher
>> these patches to your tree, and eventually tell me to pull from your
>> repository?
>>
>> Thanks, all.
>
> Junio,
>
> Thank you and Dscho for the detailed reviews. But, there is no response from
> Pratyush in over a month, is there a different maintainer then who should take
> this?
Almost 2 months now... I'm sorry. I just do not find enough time or
energy for git-gui these days. More on that later.
For now, I took a brief look at the patches. They look good to me. I
appreciate the detailed commit messages. I did not test them since I do
not have a Windows setup currently, but I believe Johannes did so it's
all good for me.
Applied to git-gui/master. Will send a pull request soon.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2023-08-24 15:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-24 21:23 [PATCH v0 0/4] Remove obsolete Cygwin support from git-gui Mark Levedahl
2023-06-24 21:23 ` [PATCH v0 1/4] git gui Makefile - remove Cygwin modiifications Mark Levedahl
2023-06-24 21:23 ` [PATCH v0 2/4] git-gui - remove obsolete Cygwin specific code Mark Levedahl
2023-06-25 2:56 ` Eric Sunshine
2023-06-25 11:29 ` Mark Levedahl
2023-06-24 21:23 ` [PATCH v0 3/4] git-gui - use cygstart to browse on Cygwin Mark Levedahl
2023-06-24 21:23 ` [PATCH v0 4/4] git-gui - use mkshortcut " Mark Levedahl
2023-06-24 23:30 ` [PATCH v0 0/4] Remove obsolete Cygwin support from git-gui Junio C Hamano
2023-06-24 23:35 ` Junio C Hamano
2023-06-25 11:28 ` Mark Levedahl
2023-06-25 11:26 ` Mark Levedahl
2023-06-25 12:10 ` Mark Levedahl
2023-06-25 15:46 ` Junio C Hamano
2023-06-25 17:01 ` Mark Levedahl
2023-06-26 15:52 ` Junio C Hamano
2023-06-26 16:55 ` Mark Levedahl
2023-06-26 16:53 ` [PATCH v1 " Mark Levedahl
2023-06-26 16:53 ` [PATCH v1 1/4] git gui Makefile - remove Cygwin modifications Mark Levedahl
2023-06-26 16:53 ` [PATCH v1 2/4] git-gui - remove obsolete Cygwin specific code Mark Levedahl
2023-06-26 16:53 ` [PATCH v1 3/4] git-gui - use cygstart to browse on Cygwin Mark Levedahl
2023-06-26 16:53 ` [PATCH v1 4/4] git-gui - use mkshortcut " Mark Levedahl
2023-06-27 11:51 ` [PATCH v1 0/4] Remove obsolete Cygwin support from git-gui Johannes Schindelin
2023-06-27 17:52 ` Junio C Hamano
2023-08-05 14:47 ` Mark Levedahl
2023-08-24 15:54 ` Pratyush Yadav [this message]
2023-08-29 16:03 ` Mark Levedahl
2023-08-29 16:18 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mafs01qfse8re.fsf@amazon.de \
--to=me@yadavpratyush$(echo .)com \
--cc=adam@dinwoodie$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=johannes.schindelin@gmx$(echo .)de \
--cc=mdl123@verizon$(echo .)net \
--cc=mlevedahl@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox