From: Andreas Schwab <schwab@suse•de>
To: Johannes Schindelin <Johannes.Schindelin@gmx•de>
Cc: Jeff King <peff@peff•net>, Johannes Sixt <j6t@kdbg•org>,
git@vger•kernel.org
Subject: Re: [PATCH] t6026-merge-attr: don't fail if sleep exits early
Date: Wed, 09 Nov 2016 15:36:40 +0100 [thread overview]
Message-ID: <mvmzil8btzb.fsf@hawking.suse.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1611091437280.72596@virtualbox> (Johannes Schindelin's message of "Wed, 9 Nov 2016 14:47:13 +0100 (CET)")
On Nov 09 2016, Johannes Schindelin <Johannes.Schindelin@gmx•de> wrote:
> The reason why we do not ignore kill errors is that we want to make sure
> that the script *actually ran*. Otherwise, the thing we need to test here
> does not necessarily get tested.
That can be tested by looking for the pid file.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse•de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
next prev parent reply other threads:[~2016-11-09 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 17:03 [PATCH] t6026-merge-attr: don't fail if sleep exits early Andreas Schwab
2016-11-08 20:05 ` Jeff King
2016-11-09 13:47 ` Johannes Schindelin
2016-11-09 14:36 ` Andreas Schwab [this message]
2016-11-09 15:31 ` Jeff King
2016-11-10 8:31 ` [PATCH v2] " Andreas Schwab
2016-11-10 19:20 ` Junio C Hamano
2016-11-10 21:55 ` Johannes Schindelin
2016-11-10 22:30 ` Junio C Hamano
2016-11-10 22:35 ` Jeff King
2016-11-10 22:55 ` Junio C Hamano
2016-11-10 23:03 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mvmzil8btzb.fsf@hawking.suse.de \
--to=schwab@suse$(echo .)de \
--cc=Johannes.Schindelin@gmx$(echo .)de \
--cc=git@vger$(echo .)kernel.org \
--cc=j6t@kdbg$(echo .)org \
--cc=peff@peff$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox