public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Linus Arver <linusa@google•com>
To: Philippe Blain via GitGitGadget <gitgitgadget@gmail•com>,
	git@vger•kernel.org
Cc: Steffen Prohaska <prohaska@zib•de>,
	Eric Sunshine <sunshine@sunshineco•com>,
	Philippe Blain <levraiphilippeblain@gmail•com>
Subject: Re: [PATCH v2] completion: improve doc for complex aliases
Date: Thu, 14 Sep 2023 15:33:25 -0700	[thread overview]
Message-ID: <owlymsxojsga.fsf@fine.c.googlers.com> (raw)
In-Reply-To: <pull.1585.v2.git.1694538135853.gitgitgadget@gmail.com>

"Philippe Blain via GitGitGadget" <gitgitgadget@gmail•com> writes:

> From: Philippe Blain <levraiphilippeblain@gmail•com>
>
> The completion code can be told to use a particular completion for
> aliases that shell out by using ': git <cmd> ;' as the first command of
> the alias. This only works if <cmd> and the semicolon are separated by a
> space, since if the space is missing __git_aliased_command returns (for
> example) 'checkout;' instead of just 'checkout', and then
> __git_complete_command fails to find a completion for 'checkout;'.
>
> The examples have that space but it's not clear if it's just for
> style or if it's mandatory. Explicitly mention it.
>
> Signed-off-by: Philippe Blain <levraiphilippeblain@gmail•com>
> ---
>     completion: improve doc for complex aliases
>     
>     Changes since v1:
>     
>      * fixed the typo pointed out by Eric
>      * added an explanation of why the space is mandatory, as suggested by
>        Linus
>

Thanks for the investigation. The commit message reads much better now.

This LGTM, but I think Junio's review comments [1] are worth
considering. I'll respond there also.

[1] https://lore.kernel.org/git/xmqqo7i6khxv.fsf@gitster.g/#t 

next prev parent reply	other threads:[~2023-09-14 22:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-09 15:49 [PATCH] completion: improve doc for complex aliases Philippe Blain via GitGitGadget
2023-09-10  2:02 ` Eric Sunshine
2023-09-12  1:04 ` Linus Arver
2023-09-12 12:13   ` Philippe Blain
2023-09-12 17:02 ` [PATCH v2] " Philippe Blain via GitGitGadget
2023-09-13  0:58   ` Junio C Hamano
2023-09-14 22:50     ` Linus Arver
2023-09-14 22:33   ` Linus Arver [this message]
2023-09-20 18:28   ` [PATCH] completion: loosen and document the requirement around completing alias Junio C Hamano
2023-09-20 18:46     ` Junio C Hamano
2023-09-22 18:31       ` Linus Arver
2023-09-22 19:49         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=owlymsxojsga.fsf@fine.c.googlers.com \
    --to=linusa@google$(echo .)com \
    --cc=git@vger$(echo .)kernel.org \
    --cc=gitgitgadget@gmail$(echo .)com \
    --cc=levraiphilippeblain@gmail$(echo .)com \
    --cc=prohaska@zib$(echo .)de \
    --cc=sunshine@sunshineco$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox