Subject: [PATCH v3 0/3] repo-settings: fix checking for fetch.negotiationAlgorithm=default

From: "Elijah Newren via GitGitGadget" <[email-masked]>
Date: Tue, 01 Feb 2022 17:00:25 +0000

This regression is not new in v2.35; it first appeared in v2.34. So, not
urgent.

Changes since v2:

 * Also fix the fact that fetch.negotationAlgorithm=$BOGUS_VALUE no longer
   errors out (yet another regression, this one dating back to v2.24.0), and
   add a test to make sure we don't regress it again.
 * Add 'consecutive' as a synonym for 'default', and remove 'default' from
   the documentation to guide people towards using 'consecutive' when they
   want the classic behavior.

Changes since v1:

 * Put the common code in two testcases into a function, and then just
   invoked it from each

Elijah Newren (3):
  repo-settings: fix checking for fetch.negotiationAlgorithm=default
  repo-settings: fix error handling for unknown values
  repo-settings: name the default fetch.negotiationAlgorithm
    'consecutive'

 Documentation/config/fetch.txt | 21 ++++++++++-----------
 fetch-negotiator.c             |  2 +-
 repo-settings.c                |  7 ++++++-
 repository.h                   |  2 +-
 t/t5500-fetch-pack.sh          | 24 +++++++++++++++++++++---
 5 files changed, 39 insertions(+), 17 deletions(-)

base-commit: 89bece5c8c96f0b962cfc89e63f82d603fd60bed
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1131%2Fnewren%2Ffix-fetch-negotiation-algorithm-equals-default-v3
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1131/newren/fix-fetch-negotiation-algorithm-equals-default-v3
Pull-Request: https://github.com/gitgitgadget/git/pull/1131

Range-diff vs v2:

 1:  633c873b513 ! 1:  df0ec5ffe98 repo-settings: fix checking for fetch.negotiationAlgorithm=default
     @@ t/t5500-fetch-pack.sh: test_expect_success 'use ref advertisement to prune "have
      +test_expect_success 'same as last but with config overrides' '
      +	test_negotiation_algorithm_default \
      +		-c feature.experimental=true \
     -+		-c fetch.negotiationAlgorithm=default \
     ++		-c fetch.negotiationAlgorithm=default
       '
       
       test_expect_success 'filtering by size' '
 -:  ----------- > 2:  23f692b81be repo-settings: fix error handling for unknown values
 -:  ----------- > 3:  7b28c527a90 repo-settings: name the default fetch.negotiationAlgorithm 'consecutive'

-- 
gitgitgadget