Subject: [PATCH] read-cache.c: reduce unnecessary cache entry name copying

From: "ZheNing Hu via GitGitGadget" <[email-masked]>
Date: Sun, 05 Jun 2022 13:37:28 +0000

From: ZheNing Hu <[email-masked]>

In function create_from_disk, we have already copy the cache
entries name from disk or previous cache entry, we can reduce
unnecessary copy before that.

Signed-off-by: ZheNing Hu <[email-masked]>
---
    read-cache.c: reduce unnecessary cache entry name copying
    
    Index cache entries name are copied twice wrongly, so reduce the first
    one to fix it.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1249%2Fadlternative%2Fzh%2Frm-ce-copy-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1249/adlternative/zh/rm-ce-copy-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1249

 read-cache.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/read-cache.c b/read-cache.c
index 96ce489c7c5..e61af3a3d4d 100644
--- a/read-cache.c
+++ b/read-cache.c
@@ -1944,8 +1944,6 @@ static struct cache_entry *create_from_disk(struct mem_pool *ce_mem_pool,
 	ce->ce_namelen = len;
 	ce->index = 0;
 	oidread(&ce->oid, ondisk->data);
-	memcpy(ce->name, name, len);
-	ce->name[len] = '\0';
 
 	if (expand_name_field) {
 		if (copy_len)

base-commit: ab336e8f1c8009c8b1aab8deb592148e69217085
-- 
gitgitgadget