From: "Tony Tung via GitGitGadget" <gitgitgadget@gmail•com>
To: git@vger•kernel.org
Cc: Elijah Newren <newren@gmail•com>, Tony Tung <tonytung@merly•org>,
Tony Tung <tonytung@merly•org>
Subject: [PATCH v2 0/2] sequencer: remove use of hardcoded comment char
Date: Tue, 31 Oct 2023 05:09:10 +0000 [thread overview]
Message-ID: <pull.1603.v2.git.1698728952.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1603.git.1698635292629.gitgitgadget@gmail.com>
Instead of using the hardcoded # , use the user-defined comment_line_char.
Adds a test to prevent regressions.
Tony Tung (2):
sequencer: remove use of comment character
sequencer: fix remaining hardcoded comment char
sequencer.c | 21 +++++++++++++------
t/t3404-rebase-interactive.sh | 39 +++++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+), 6 deletions(-)
base-commit: 2e8e77cbac8ac17f94eee2087187fa1718e38b14
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1603%2Fttung%2Fttung%2Fcommentchar-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1603/ttung/ttung/commentchar-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/1603
Range-diff vs v1:
1: 10598a56d64 = 1: 10598a56d64 sequencer: remove use of comment character
-: ----------- > 2: c9f4ff34dbd sequencer: fix remaining hardcoded comment char
--
gitgitgadget
next prev parent reply other threads:[~2023-10-31 5:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 3:08 [PATCH] sequencer: remove use of comment character Tony Tung via GitGitGadget
2023-10-30 4:00 ` Junio C Hamano
2023-10-30 17:26 ` Elijah Newren
2023-10-30 23:35 ` Junio C Hamano
2023-10-31 4:42 ` Tony Tung
2023-10-31 4:50 ` Tony Tung
2023-10-31 5:33 ` Junio C Hamano
2023-10-31 6:20 ` Elijah Newren
2023-10-31 5:09 ` Tony Tung via GitGitGadget [this message]
2023-10-31 5:09 ` [PATCH v2 1/2] " Tony Tung via GitGitGadget
2023-10-31 11:43 ` Phillip Wood
2023-11-01 4:59 ` Junio C Hamano
2023-10-31 5:09 ` [PATCH v2 2/2] sequencer: fix remaining hardcoded comment char Tony Tung via GitGitGadget
2023-10-31 11:27 ` Phillip Wood
2023-10-31 6:55 ` [PATCH v2 0/2] sequencer: remove use of " Elijah Newren
2023-10-31 11:18 ` Phillip Wood
2023-11-01 0:16 ` Junio C Hamano
2023-11-01 0:21 ` Elijah Newren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1603.v2.git.1698728952.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=newren@gmail$(echo .)com \
--cc=tonytung@merly$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox