From: "Piotr Szlazak via GitGitGadget" <gitgitgadget@gmail•com>
To: git@vger•kernel.org
Cc: Jeff King <peff@peff•net>,
"brian m. carlson" <sandals@crustytoothpaste•net>,
Junio C Hamano <gitster@pobox•com>,
Piotr Szlazak <piotr.szlazak@gmail•com>,
Piotr Szlazak <piotr.szlazak@gmail•com>
Subject: [PATCH v2] doc: update http.cookieFile with in-memory cookie processing
Date: Thu, 11 Jul 2024 08:36:48 +0000 [thread overview]
Message-ID: <pull.1733.v2.git.git.1720687008915.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.1733.git.git.1719177846725.gitgitgadget@gmail.com>
From: Piotr Szlazak <piotr.szlazak@gmail•com>
Information added how to enable in-memory cookies
processing. Cookies from server will be accepted and send
back in successive requests within same connection.
At the moment documentation only mentions how to read
cookies from the given file and how to save them to the file
using http.saveCookies.
curl / libcurl will process cookies in memory if file name
is blank. Check curl manpage:
https://curl.se/docs/manpage.html#-b
This is described here in more details:
https://everything.curl.dev/http/cookies/engine.html
And also explained here:
https://www.youtube.com/watch?v=V5vZWHP-RqU&t=11459s
Git documentation was updated to include suggestion how to
enable this by setting empty value for http.cookieFile.
Changes since V1:
- better explanation what in-memory processing means
- added explanation that http.saveCookies does not work
if http.cookieFile was set to empty value
Signed-off-by: Piotr Szlazak <piotr.szlazak@gmail•com>
---
Update http.cookieFile with in-memory cookie processing
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1733%2Fpszlazak%2Fdocumentation-cookieFile-in-memory-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1733/pszlazak/documentation-cookieFile-in-memory-v2
Pull-Request: https://github.com/git/git/pull/1733
Range-diff vs v1:
1: 5e9b3924224 ! 1: c4d41b5884d doc: update http.cookieFile with in-memory cookie processing
@@ Commit message
Git documentation was updated to include suggestion how to
enable this by setting empty value for http.cookieFile.
+ Changes since V1:
+ - better explanation what in-memory processing means
+ - added explanation that http.saveCookies does not work
+ if http.cookieFile was set to empty value
+
Signed-off-by: Piotr Szlazak <piotr.szlazak@gmail•com>
## Documentation/config/http.txt ##
@@ Documentation/config/http.txt: http.extraHeader::
- in the Git http session, if they match the server. The file format
- of the file to read cookies from should be plain HTTP headers or
- the Netscape/Mozilla cookie file format (see `curl(1)`).
+- NOTE that the file specified with http.cookieFile is used only as
+- input unless http.saveCookies is set.
+ which should be used in the Git http session, if they match the server.
+ The file format of the file to read cookies from should be plain HTTP
+ headers or the Netscape/Mozilla cookie file format (see `curl(1)`).
-+ Set it to empty value, to enable in-memory cookies processing.
- NOTE that the file specified with http.cookieFile is used only as
- input unless http.saveCookies is set.
++ Set it to empty value (''), to accept only new cookies from the server and
++ send them back in successive requests within same connection. NOTE that the
++ file specified with http.cookieFile is used only as input unless
++ http.saveCookies is set.
+
+ http.saveCookies::
+ If set, store cookies received during requests to the file specified by
+- http.cookieFile. Has no effect if http.cookieFile is unset.
++ http.cookieFile. Has no effect if http.cookieFile is not set or set to empty
++ value ('').
+ http.version::
+ Use the specified HTTP protocol version when communicating with a server.
Documentation/config/http.txt | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/Documentation/config/http.txt b/Documentation/config/http.txt
index 2d4e0c9b869..e71ca11c10b 100644
--- a/Documentation/config/http.txt
+++ b/Documentation/config/http.txt
@@ -78,16 +78,18 @@ http.extraHeader::
http.cookieFile::
The pathname of a file containing previously stored cookie lines,
- which should be used
- in the Git http session, if they match the server. The file format
- of the file to read cookies from should be plain HTTP headers or
- the Netscape/Mozilla cookie file format (see `curl(1)`).
- NOTE that the file specified with http.cookieFile is used only as
- input unless http.saveCookies is set.
+ which should be used in the Git http session, if they match the server.
+ The file format of the file to read cookies from should be plain HTTP
+ headers or the Netscape/Mozilla cookie file format (see `curl(1)`).
+ Set it to empty value (''), to accept only new cookies from the server and
+ send them back in successive requests within same connection. NOTE that the
+ file specified with http.cookieFile is used only as input unless
+ http.saveCookies is set.
http.saveCookies::
If set, store cookies received during requests to the file specified by
- http.cookieFile. Has no effect if http.cookieFile is unset.
+ http.cookieFile. Has no effect if http.cookieFile is not set or set to empty
+ value ('').
http.version::
Use the specified HTTP protocol version when communicating with a server.
base-commit: 66ac6e4bcd111be3fa9c2a6b3fafea718d00678d
--
gitgitgadget
next prev parent reply other threads:[~2024-07-11 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 21:24 [PATCH] doc: update http.cookieFile with in-memory cookie processing Piotr Szlazak via GitGitGadget
2024-07-09 21:37 ` Piotr Szlazak
2024-07-09 22:30 ` Junio C Hamano
2024-07-09 23:05 ` Junio C Hamano
2024-07-11 9:18 ` Piotr Szlazak
2024-07-11 8:36 ` Piotr Szlazak via GitGitGadget [this message]
2024-07-11 16:05 ` [PATCH v2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1733.v2.git.git.1720687008915.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=piotr.szlazak@gmail$(echo .)com \
--cc=sandals@crustytoothpaste$(echo .)net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox