Subject: [PATCH v4 0/8] git-prompt: support more shells v4

From: "Avi Halachmi via GitGitGadget" <[email-masked]>
Date: Tue, 20 Aug 2024 01:48:24 +0000

This addresses review comments on part 5/8 v3 (git-prompt: add some missing
quotes) to fix minor wording issues at the commit message.

Hopefully this is the last wording fixup.

Avi Halachmi (:avih) (8):
  git-prompt: use here-doc instead of here-string
  git-prompt: fix uninitialized variable
  git-prompt: don't use shell arrays
  git-prompt: replace [[...]] with standard code
  git-prompt: add some missing quotes
  git-prompt: don't use shell $'...'
  git-prompt: ta-da! document usage in other shells
  git-prompt: support custom 0-width PS1 markers

 contrib/completion/git-prompt.sh | 191 ++++++++++++++++++++-----------
 1 file changed, 126 insertions(+), 65 deletions(-)

base-commit: d19b6cd2dd72dc811f19df4b32c7ed223256c3ee
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1750%2Favih%2Fprompt-compat-v4
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1750/avih/prompt-compat-v4
Pull-Request: https://github.com/git/git/pull/1750

Range-diff vs v3:

 1:  9ce5ddadf0b = 1:  9ce5ddadf0b git-prompt: use here-doc instead of here-string
 2:  680ecb52404 = 2:  680ecb52404 git-prompt: fix uninitialized variable
 3:  7e994eae7bc = 3:  7e994eae7bc git-prompt: don't use shell arrays
 4:  232340902a1 = 4:  232340902a1 git-prompt: replace [[...]] with standard code
 5:  3a41ad889cc ! 5:  18ff70db6b3 git-prompt: add some missing quotes
     @@ Commit message
          in real life, but the fixes improve correctness, and would prevent
          bugs in some uncommon cases, such as weird IFS values.
      
     -    Listing some portability guideline here for future reference.
     +    Listing some portability guidelines here for future reference.
      
          I'm leaving it to someone else to decide whether to include
     -    it in the file itself, place is as a new file, or not.
     +    it in the file itself, place it as a new file, or not.
      
          ---------
      
     @@ Commit message
            Bad:  [ $mode = yes ];   local s=*   x=$y   e=$?   z=$(cmd...)
      
          The arguments to "local" do look like assignments, but they're not
     -    the assignment part of a simple command. they're at the command part.
     +    the assignment part of a simple command; they're at the command part.
      
          Still at the command part, no need to quote non-expandable values:
            Good:                 local x=   y=yes;   echo OK
 6:  e735a1696a0 = 6:  48aa31feedb git-prompt: don't use shell $'...'
 7:  e70440e669a = 7:  cd20b830b24 git-prompt: ta-da! document usage in other shells
 8:  633e71a01d3 = 8:  cb705d5fc8e git-prompt: support custom 0-width PS1 markers

-- 
gitgitgadget