From: "Lidong Yan via GitGitGadget" <gitgitgadget@gmail•com>
To: git@vger•kernel.org
Cc: Lidong Yan <502024330056@smail•nju.edu.cn>,
Lidong Yan <502024330056@smail•nju.edu.cn>
Subject: [PATCH] commit-graph: fix start_delayed_progress() leak
Date: Wed, 04 Jun 2025 03:11:15 +0000 [thread overview]
Message-ID: <pull.1986.git.git.1749006675784.gitgitgadget@gmail.com> (raw)
From: Lidong Yan <502024330056@smail•nju.edu.cn>
In commit-graph.c:graph_write(), if read_one_commit() failed,
progress allocated in start_delayed_progress() will leak. Add
stop_progress() before goto cleanup.
Signed-off-by: Lidong Yan <502024330056@smail•nju.edu.cn>
---
commit-graph: fix start_delayed_progress() leak
In commit-graph.c:graph_write(), if read_one_commit() failed, progress
allocated in start_delayed_progress() will leak. Add stop_progress()
before goto cleanup.
Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1986%2Fbrandb97%2Ffix-graph-write-leak-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1986/brandb97/fix-graph-write-leak-v1
Pull-Request: https://github.com/git/git/pull/1986
builtin/commit-graph.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/builtin/commit-graph.c b/builtin/commit-graph.c
index a783a86e797..ee48980248f 100644
--- a/builtin/commit-graph.c
+++ b/builtin/commit-graph.c
@@ -311,6 +311,7 @@ static int graph_write(int argc, const char **argv, const char *prefix,
while (strbuf_getline(&buf, stdin) != EOF) {
if (read_one_commit(&commits, progress, buf.buf)) {
result = 1;
+ stop_progress(&progress);
goto cleanup;
}
}
base-commit: 7014b55638da979331baf8dc31c4e1d697cf2d67
--
gitgitgadget
next reply other threads:[~2025-06-04 3:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 3:11 Lidong Yan via GitGitGadget [this message]
2025-06-04 7:42 ` [PATCH] commit-graph: fix start_delayed_progress() leak Patrick Steinhardt
2025-06-04 7:47 ` lidongyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pull.1986.git.git.1749006675784.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail$(echo .)com \
--cc=502024330056@smail$(echo .)nju.edu.cn \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox