public inbox for git@vger.kernel.org 
 help / color / mirror / Atom feed

From: Jan Larres <jan@majutsushi•net>
To: git@vger•kernel.org
Subject: Re: check-attr doesn't respect recursive definitions
Date: Wed, 3 Apr 2013 10:05:24 +0000 (UTC)	[thread overview]
Message-ID: <slrnklnvo6.jdl.jan@majutsushi.net> (raw)
In-Reply-To: 20130402191641.GB17784@sigill.intra.peff.net

Thanks for the clarifications. Just a quick comment about the summary:

Jeff King <peff@peff•net> wrote:
> Yeah, I had the same thought. So you would have to either:
>
>   1. Hook the feature into git-archive, which knows about how it
>      recurses, and can report the correct set of paths.
>
> or
>
>   2. Tell check-attr (or some post-processor) to apply the attribute to
>      elements below the path (or possibly to prune out such paths). This
>      is not the same as recursive application, because you cannot negate
>      it (i.e., you actually find out the final attrs for both "foo" and
>      "foo/bar", and then say "the attr for 'foo' overrides the attr for
>      'foo/bar'".
>
> I posted a patch for (1), but it felt not-very-general. But (2) also
> feels gross and not very general. Even though it could in theory be used
> for things besides git-archive, it is really just applying git-archive's
> pruning rule, which other programs likely don't care about.

I actually think the first approach is not such a bad idea, it would
make "archive" more of a general-purpose archiving tool/helper for the
repository rather than just something for the special cases of tars and
zips. But I guess that's somewhat subjective.

Cheers,
Jan

next prev parent reply	other threads:[~2013-04-03 10:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-30  9:45 check-attr doesn't respect recursive definitions Jan Larres
2013-04-02 14:31 ` Jeff King
2013-04-02 14:48   ` Jeff King
2013-04-02 16:11   ` Junio C Hamano
2013-04-02 16:30     ` Jeff King
2013-04-02 16:43       ` Junio C Hamano
2013-04-02 16:51         ` Jeff King
2013-04-02 17:15           ` Jeff King
2013-04-02 17:16           ` Junio C Hamano
2013-04-02 19:16             ` Jeff King
2013-04-03 10:05               ` Jan Larres [this message]
2013-04-05  2:09 ` Duy Nguyen
2013-04-05 12:04   ` Jan Larres

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=slrnklnvo6.jdl.jan@majutsushi.net \
    --to=jan@majutsushi$(echo .)net \
    --cc=git@vger$(echo .)kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox