From: Catalin Marinas <catalin.marinas@arm•com>
To: git@vger•kernel.org
Subject: Re: cogito-0.10 broken for cg-commit < logmessagefile
Date: Wed, 08 Jun 2005 17:28:22 +0100 [thread overview]
Message-ID: <tnxhdg8g6e1.fsf@arm.com> (raw)
In-Reply-To: <20050608144632.A28042@flint.arm.linux.org.uk> (Russell King's message of "Wed, 8 Jun 2005 14:46:32 +0100")
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
Russell King <rmk@arm•linux.org.uk> wrote:
> The command in the subject prepends the log message with a blank line.
> This ain't good because it messes up commit messages as per Linus'
> requirements (the first line must be a summary.)
The patch below should fix the problem. There is no point in writing
the status information in a file which is read from stdin.
--
Catalin
[-- Attachment #2: cogito-stdin.diff --]
[-- Type: text/plain, Size: 410 bytes --]
Fix the log file when read from stdin
Log messages read from stdin shouldn't have additional lines.
Signed-off-by: Catalin Marinas <catalin.marinas@arm•com>
diff --git a/cg-commit b/cg-commit
--- a/cg-commit
+++ b/cg-commit
@@ -215,7 +215,7 @@ if tty -s; then
fi
fi
else
- cat >>$LOGMSG2
+ cat >$LOGMSG2
fi
# Remove heading and trailing blank lines.
grep -v ^CG: $LOGMSG2 | git-stripspace >$LOGMSG
next prev parent reply other threads:[~2005-06-08 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-08 13:46 cogito-0.10 broken for cg-commit < logmessagefile Russell King
2005-06-08 16:28 ` Catalin Marinas [this message]
2005-06-08 18:17 ` Petr Baudis
2005-06-08 20:28 ` [PATCH] Many new features for cg-diff and cg-log Dan Holmsand
2005-06-08 20:40 ` Petr Baudis
2005-06-08 21:03 ` Petr Baudis
2005-06-08 21:03 ` Dan Holmsand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tnxhdg8g6e1.fsf@arm.com \
--to=catalin.marinas@arm$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox