From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Christian Couder <christian.couder@gmail•com>
Cc: Michael Haggerty <mhagger@alum•mit.edu>,
Junio C Hamano <gitster@pobox•com>, git <git@vger•kernel.org>,
Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr>,
Louis Stuber <stuberl@ensimag•grenoble-inp.fr>
Subject: Re: [PATCH v10.1 7/7] bisect: allow any terms set by user
Date: Mon, 29 Jun 2015 09:34:15 +0200 [thread overview]
Message-ID: <vpq1tgvnf2g.fsf@anie.imag.fr> (raw)
In-Reply-To: <CAP8UFD0NjExQJHQWix1+zc4_k15e3+aC5vAv=dHipg-X+2y1sQ@mail.gmail.com> (Christian Couder's message of "Mon, 29 Jun 2015 07:08:26 +0200")
Christian Couder <christian.couder@gmail•com> writes:
> On Sun, Jun 28, 2015 at 8:46 AM, Michael Haggerty <mhagger@alum•mit.edu> wrote:
>> I understand that the user might make a mistake when marking the initial
>> commits, but as soon as bisect says
>>
>> Commit <sha1-abbrev> is an ancestor of <sha1-abbrev>, so I
>> will look for the commit that caused the transition from
>> "xyzzy" to "plugh".
>>
>> then I hope the user will notice and correct her/his mistake.
>
> This looks fragile to me. Unfortunately many users will probably not
> read it and continue, and then spend a lot of time later trying to
> understand what went wrong,
I don't understand what you mean by "went wrong". As a user, when I
discovered "git bisect", I was actually surprised that it expected one
particular order between good and bad. I would have expected to be able
to say "this is good, this is bad, tell me where it changed" without
having an idea of who's good and who's bad. In particular when bisecting
from two branches, the user knows that branch A is good, and branch B is
bad, but does not necessarily know whether it's a regression in B or a
fix in A. The fact that bisect can find out should be just "normal" from
the user point of view. There's no mistake involved, nothing to fix, and
nothing that went wrong.
> By the way we could use "mark" or "term" instead of "name" in the
> option name (like --mark-old or --term-old) and in the code too if it
> looks clearer.
I prefer "term" to "mark" because "mark" is both a verb and a noun, so
--mark-old=foo could mean both "mark foo as old" or "the name of the
marks for old commits is foo".
I think I prefer "term" to "name".
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-29 7:34 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 16:58 [PATCH v10 0/7] bisect terms Matthieu Moy
2015-06-26 16:58 ` [PATCH v10 1/7] bisect: correction of typo Matthieu Moy
2015-06-26 16:58 ` [PATCH v10 2/7] Documentation/bisect: move getting help section to the end Matthieu Moy
2015-06-26 16:58 ` [PATCH v10 3/7] Documentation/bisect: revise overall content Matthieu Moy
2015-06-26 16:58 ` [PATCH v10 4/7] bisect: replace hardcoded "bad|good" by variables Matthieu Moy
2015-06-26 16:58 ` [PATCH v10 5/7] bisect: simplify the addition of new bisect terms Matthieu Moy
2015-06-26 19:22 ` Christian Couder
2015-06-26 20:32 ` [PATCH v10.1 " Matthieu Moy
2015-06-26 21:27 ` Junio C Hamano
2015-06-26 21:37 ` Matthieu Moy
2015-06-26 16:58 ` [PATCH v10 6/7] bisect: add the terms old/new Matthieu Moy
2015-06-26 16:58 ` [PATCH v10 7/7] bisect: allow any terms set by user Matthieu Moy
2015-06-26 18:16 ` Junio C Hamano
2015-06-26 20:39 ` [PATCH v10.1 " Matthieu Moy
2015-06-26 22:25 ` Junio C Hamano
2015-06-27 4:10 ` Christian Couder
2015-06-27 4:25 ` Junio C Hamano
2015-06-27 4:51 ` Christian Couder
2015-06-27 8:32 ` Matthieu Moy
2015-06-27 18:41 ` Junio C Hamano
2015-06-29 9:51 ` Matthieu Moy
2015-06-29 16:35 ` Junio C Hamano
2015-06-28 5:51 ` Michael Haggerty
2015-06-28 6:15 ` Junio C Hamano
2015-06-28 6:46 ` Michael Haggerty
2015-06-28 7:32 ` Junio C Hamano
2015-06-28 11:31 ` Michael Haggerty
2015-06-28 18:51 ` Junio C Hamano
2015-06-29 7:27 ` Matthieu Moy
2015-06-29 16:40 ` Junio C Hamano
2015-06-29 5:08 ` Christian Couder
2015-06-29 7:34 ` Matthieu Moy [this message]
2015-06-29 8:08 ` Christian Couder
2015-06-29 9:32 ` Matthieu Moy
2015-06-29 10:55 ` Christian Couder
2015-06-29 15:19 ` Matthieu Moy
2015-06-26 20:29 ` [PATCH v10 " Christian Couder
2015-06-26 20:59 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq1tgvnf2g.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=christian.couder@gmail$(echo .)com \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=mhagger@alum$(echo .)mit.edu \
--cc=stuberl@ensimag$(echo .)grenoble-inp.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox