Subject: Re: [PATCH v13 11/12] tag.c: implement '--format' option

From: Matthieu Moy <[email-masked]>
Date: Sun, 23 Aug 2015 21:56:54 +0200

Karthik Nayak <[email-masked]> writes:

> --- a/Documentation/git-tag.txt
> +++ b/Documentation/git-tag.txt
> @@ -13,7 +13,8 @@ SYNOPSIS
>  	<tagname> [<commit> | <object>]
>  'git tag' -d <tagname>...
>  'git tag' [-n[<num>]] -l [--contains <commit>] [--points-at <object>]
> -	[--column[=<options>] | --no-column] [--create-reflog] [--sort=<key>] [<pattern>...]
> +	[--column[=<options>] | --no-column] [--create-reflog] [--sort=<key>]
> +	[--format=<format>] [<pattern>...]
>  'git tag' -v <tagname>...
>  
>  DESCRIPTION
> @@ -158,6 +159,11 @@ This option is only applicable when listing tags without annotation lines.
>  	The object that the new tag will refer to, usually a commit.
>  	Defaults to HEAD.
>  
> +<format>::

Shouldn't this be --format <format>, not just <format>? We usually use
the named argument in the SYNOPSIS for positional arguments, but not for
arguments following an option.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/