From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Louis-Alexandre Stuber <stuberl@ensimag•grenoble-inp.fr>
Cc: Junio C Hamano <gitster@pobox•com>,
Antoine Delaite <antoine.delaite@ensimag•grenoble-inp.fr>,
git@vger•kernel.org,
remi lespinet <remi.lespinet@ensimag•grenoble-inp.fr>,
remi galan-alfonso <remi.galan-alfonso@ensimag•grenoble-inp.fr>,
guillaume pages <guillaume.pages@ensimag•grenoble-inp.fr>,
chriscool@tuxfamily•org, thomasxnguy@gmail•com,
valentinduperray@gmail•com, jch2355@gmail•com
Subject: Re: [PATCH 3/4] bisect: simplify the add of new bisect terms
Date: Wed, 10 Jun 2015 17:24:11 +0200 [thread overview]
Message-ID: <vpq381zsi1w.fsf@anie.imag.fr> (raw)
In-Reply-To: <2070840481.381260.1433929304815.JavaMail.zimbra@ensimag.grenoble-inp.fr> (Louis-Alexandre Stuber's message of "Wed, 10 Jun 2015 11:41:44 +0200 (CEST)")
Louis-Alexandre Stuber <stuberl@ensimag•grenoble-inp.fr> writes:
> But ENOENT is not a normal case at all. Should we not treat it the same
> way as other fopen() errors ? (either going on with default case or
> returning an error)
>
> Would :
>
>> if (!fp) {
>> die("could not read file '%s': %s",
>> filename, strerror(errno));
>> } else {
>
> be ok ?
That would be much better than what we had in the patch, which did not
look like an error at all:
+ FILE *fp = fopen(filename, "r");
+
+ if (!fp) {
+ name_bad = "bad";
+ name_good = "good";
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-06-10 15:25 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-08 20:22 [PATCH 1/4] bisect : correction of typo Antoine Delaite
2015-06-08 20:22 ` [PATCH 2/4] bisect: replace hardcoded "bad|good" by variables Antoine Delaite
2015-06-08 20:30 ` Junio C Hamano
2015-06-09 6:45 ` Matthieu Moy
2015-06-09 8:12 ` Christian Couder
2015-06-09 12:39 ` Matthieu Moy
2015-06-09 19:18 ` Junio C Hamano
2015-06-08 20:22 ` [PATCH 3/4] bisect: simplify the add of new bisect terms Antoine Delaite
2015-06-08 20:42 ` Junio C Hamano
2015-06-09 18:17 ` Antoine Delaite
2015-06-10 16:30 ` Matthieu Moy
2015-06-09 7:01 ` Matthieu Moy
2015-06-09 8:39 ` Christian Couder
2015-06-09 20:17 ` Louis-Alexandre Stuber
2015-06-10 0:39 ` Junio C Hamano
2015-06-10 7:15 ` Louis-Alexandre Stuber
2015-06-10 8:03 ` Matthieu Moy
2015-06-10 9:41 ` Louis-Alexandre Stuber
2015-06-10 15:24 ` Matthieu Moy [this message]
2015-06-10 15:10 ` Junio C Hamano
2015-06-10 15:25 ` Matthieu Moy
2015-06-10 16:11 ` Junio C Hamano
2015-06-08 20:22 ` [PATCH 4/4] bisect: add the terms old/new Antoine Delaite
2015-06-08 21:21 ` Junio C Hamano
[not found] <1183699596.323718.1433875699237.JavaMail.zimbra@ensimag.grenoble-inp.fr>
2015-06-10 7:09 ` [PATCH 3/4] bisect: simplify the add of new bisect terms Antoine Delaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq381zsi1w.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=antoine.delaite@ensimag$(echo .)grenoble-inp.fr \
--cc=chriscool@tuxfamily$(echo .)org \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=guillaume.pages@ensimag$(echo .)grenoble-inp.fr \
--cc=jch2355@gmail$(echo .)com \
--cc=remi.galan-alfonso@ensimag$(echo .)grenoble-inp.fr \
--cc=remi.lespinet@ensimag$(echo .)grenoble-inp.fr \
--cc=stuberl@ensimag$(echo .)grenoble-inp.fr \
--cc=thomasxnguy@gmail$(echo .)com \
--cc=valentinduperray@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox