From: Matthieu Moy <Matthieu.Moy@grenoble-inp•fr>
To: Paul Tan <pyokagan@gmail•com>
Cc: git@vger•kernel.org, Junio C Hamano <gitster@pobox•com>,
Jeff King <peff@peff•net>,
Eric Sunshine <sunshine@sunshineco•com>
Subject: Re: [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence
Date: Wed, 18 Mar 2015 17:23:36 +0100 [thread overview]
Message-ID: <vpq3852ff5j.fsf@anie.imag.fr> (raw)
In-Reply-To: <1426662276-8728-3-git-send-email-pyokagan@gmail.com> (Paul Tan's message of "Wed, 18 Mar 2015 15:04:35 +0800")
I would personnally prefer to see this squashed with PATCH 2/4: pushing
the "bisectable history" principle a bit, the state between patches 2
and 3 could be considered broken because the code does not do what the
documentation says. And as a reviewer, I like having pieces of docs
linked to the patch they document.
Paul Tan <pyokagan@gmail•com> writes:
> +Credential storage will per default
Not a native, but "per default" sounds weird and "by default" seems far
more common.
--
Matthieu Moy
http://www-verimag.imag.fr/~moy/
next prev parent reply other threads:[~2015-03-18 16:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-18 7:04 [PATCH v4 1/4] git-credential-store: support multiple credential files Paul Tan
2015-03-18 7:04 ` [PATCH v4 2/4] git-credential-store: support XDG_CONFIG_HOME Paul Tan
2015-03-18 7:04 ` [PATCH v4 3/4] docs/git-credential-store: document XDG file and precedence Paul Tan
2015-03-18 16:23 ` Matthieu Moy [this message]
2015-03-21 5:59 ` Paul Tan
2015-03-18 7:04 ` [PATCH v4 4/4] t0302: test credential-store support for XDG_CONFIG_HOME Paul Tan
2015-03-18 16:41 ` Matthieu Moy
2015-03-18 21:15 ` Eric Sunshine
2015-03-19 13:35 ` Matthieu Moy
2015-03-21 10:01 ` Paul Tan
2015-03-18 19:26 ` Eric Sunshine
2015-03-19 21:53 ` Eric Sunshine
2015-03-21 5:46 ` Paul Tan
2015-03-23 1:56 ` Eric Sunshine
2015-03-18 16:17 ` [PATCH v4 1/4] git-credential-store: support multiple credential files Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=vpq3852ff5j.fsf@anie.imag.fr \
--to=matthieu.moy@grenoble-inp$(echo .)fr \
--cc=git@vger$(echo .)kernel.org \
--cc=gitster@pobox$(echo .)com \
--cc=peff@peff$(echo .)net \
--cc=pyokagan@gmail$(echo .)com \
--cc=sunshine@sunshineco$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox