Subject: Re: [PATCH v15 11/13] tag.c: use 'ref-filter' APIs

From: Matthieu Moy <[email-masked]>
Date: Wed, 02 Sep 2015 11:09:28 +0200

Karthik Nayak <[email-masked]> writes:

> +	if (filter->lines)
> +		format = to_free = xstrfmt("%%(align:15,left)%%(refname:short)%%(end) %%(contents:lines=%d)",
> +					   filter->lines);
> +	else
> +		format = "%(refname:short)";
> +
> +	verify_ref_format(format);
> +	filter_refs(&array, filter, FILTER_REFS_TAGS);
> +	ref_array_sort(sorting, &array);
> +
> +	for (i = 0; i < array.nr; i++)
> +		show_ref_array_item(array.items[i], format, 0);

Nice :-).

(I'd cut the string argument to xstrfmt after "%(end)" to avoid long
line)

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/